Re: [PATCH V2] usb: ehci-platform: use helper variables in probe function

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2] usb: ehci-platform: use helper variables in probe function
Date	2016-08-09 16:10 +0200
Message-ID	<s4fTc-bN-41@gated-at.bofh.it> (permalink)
References	<rUnS2-vb-29@gated-at.bofh.it> <rV3xT-2IL-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 15, 2016 at 07:05:56AM +0200, Rafał Miłecki wrote:
> Probing function was using &dev->dev and dev->dev.of_node over 20 times
> so I believe it made sense to use helper variables for both of them.
> To avoid some uncommon variable name for struct device I first replaced
> existing dev variable with pdev.
> 
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> ---
> V2: Use 2 extra tabs after line break to match one of already used
>     coding styles.

Same comment here, unnecessary churn, sorry.

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH V2] usb: ehci-platform: use helper variables in probe  function Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-09 16:10 +0200

csiph-web