Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1458787 > unrolled thread

Re: [PATCH V2] usb: ehci-platform: use helper variables in probe function

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH V2] usb: ehci-platform: use helper variables in probe  function Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-09 16:10 +0200

#1458787 — Re: [PATCH V2] usb: ehci-platform: use helper variables in probe function

On Fri, Jul 15, 2016 at 07:05:56AM +0200, Rafał Miłecki wrote:
> Probing function was using &dev->dev and dev->dev.of_node over 20 times
> so I believe it made sense to use helper variables for both of them.
> To avoid some uncommon variable name for struct device I first replaced
> existing dev variable with pdev.
> 
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> ---
> V2: Use 2 extra tabs after line break to match one of already used
>     coding styles.

Same comment here, unnecessary churn, sorry.

greg k-h

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web