Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1460591

Re: [PATCH] perf tools mem: Fix -t store option for record command

From Jiri Olsa <jolsa@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] perf tools mem: Fix -t store option for record command
Date 2016-08-11 17:00 +0200
Message-ID <s4ZCF-58o-21@gated-at.bofh.it> (permalink)
References <s4U0i-1xh-27@gated-at.bofh.it> <s4WOt-3kP-1@gated-at.bofh.it> <s4WY9-3Dt-7@gated-at.bofh.it> <s4ZsZ-54X-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Aug 11, 2016 at 11:46:46AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Aug 11, 2016 at 02:00:32PM +0200, Jiri Olsa escreveu:
> > On Thu, Aug 11, 2016 at 08:51:38AM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Thu, Aug 11, 2016 at 10:50:57AM +0200, Jiri Olsa escreveu:
> > > > Michael reported 'perf mem -t store record' being broken.
> > > > The reason is latest rework of this area:
> > > >   commit acbe613e0c03 ("perf tools: Add monitored events array")
> > > > 
> > > > We don't mark perf_mem_events store record when -t store
> > > > option is specified.
> > > > 
> > > > Fixes: commit acbe613e0c03 ("perf tools: Add monitored events array")
> > >          ^^^^^^
> > > I'll remove this extraneous bit
> > 
> > well, checkpatch script complained about that when
> > I did not put it there..  but I don't mind ;-)
> 
> Huh?

ah that was the other line with the commit number,
the one with Fixes: tag is ok.. nevermind, sry for noise ;-)

jirka


---
[jolsa@krava linux-perf]$ ./scripts/checkpatch.pl 0001-perf-tools-mem-Fix-t-store-option-for-record-command.patch 
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit acbe613e0c03 ("perf tools: Add monitored events array")'
#8: 
  acbe613e0c03 ("perf tools: Add monitored events array")

total: 1 errors, 0 warnings, 9 lines checked

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] perf tools mem: Fix -t store option for record command Jiri Olsa <jolsa@kernel.org> - 2016-08-11 11:00 +0200
  Re: [PATCH] perf tools mem: Fix -t store option for record command Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-11 14:00 +0200
    Re: [PATCH] perf tools mem: Fix -t store option for record command Jiri Olsa <jolsa@redhat.com> - 2016-08-11 14:10 +0200
      Re: [PATCH] perf tools mem: Fix -t store option for record command Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-11 16:50 +0200
        Re: [PATCH] perf tools mem: Fix -t store option for record command Jiri Olsa <jolsa@redhat.com> - 2016-08-11 17:00 +0200
  [tip:perf/urgent] perf tools mem: Fix -t store option for record  command tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-08-16 20:20 +0200

csiph-web