Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1460449

Re: [PATCH] perf tools mem: Fix -t store option for record command

Show all headers | View raw

On Thu, Aug 11, 2016 at 08:51:38AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Aug 11, 2016 at 10:50:57AM +0200, Jiri Olsa escreveu:
> > Michael reported 'perf mem -t store record' being broken.
> > The reason is latest rework of this area:
> >   commit acbe613e0c03 ("perf tools: Add monitored events array")
> > 
> > We don't mark perf_mem_events store record when -t store
> > option is specified.
> > 
> > Fixes: commit acbe613e0c03 ("perf tools: Add monitored events array")
>          ^^^^^^
> I'll remove this extraneous bit

well, checkpatch script complained about that when
I did not put it there..  but I don't mind ;-)

jirka

> 
> > Reported-by: Michael Petlan <mpetlan@redhat.com>
> > Link: http://lkml.kernel.org/n/tip-dbytnk7urdnnaw7ckdu1w7lq@git.kernel.org
> > Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> > ---
> >  tools/perf/builtin-mem.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c
> > index d608a2c9e48c..d1ce29be560e 100644
> > --- a/tools/perf/builtin-mem.c
> > +++ b/tools/perf/builtin-mem.c
> > @@ -88,6 +88,9 @@ static int __cmd_record(int argc, const char **argv, struct perf_mem *mem)
> >  	if (mem->operation & MEM_OPERATION_LOAD)
> >  		perf_mem_events[PERF_MEM_EVENTS__LOAD].record = true;
> >  
> > +	if (mem->operation & MEM_OPERATION_STORE)
> > +		perf_mem_events[PERF_MEM_EVENTS__STORE].record = true;
> > +
> >  	if (perf_mem_events[PERF_MEM_EVENTS__LOAD].record)
> >  		rec_argv[i++] = "-W";
> >  
> > -- 
> > 2.4.11

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf tools mem: Fix -t store option for record command Jiri Olsa <jolsa@kernel.org> - 2016-08-11 11:00 +0200
  Re: [PATCH] perf tools mem: Fix -t store option for record command Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-11 14:00 +0200
    Re: [PATCH] perf tools mem: Fix -t store option for record command Jiri Olsa <jolsa@redhat.com> - 2016-08-11 14:10 +0200
      Re: [PATCH] perf tools mem: Fix -t store option for record command Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-11 16:50 +0200
        Re: [PATCH] perf tools mem: Fix -t store option for record command Jiri Olsa <jolsa@redhat.com> - 2016-08-11 17:00 +0200
  [tip:perf/urgent] perf tools mem: Fix -t store option for record  command tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-08-16 20:20 +0200

csiph-web