Re: [patch] tty: amiserial.c: remove a double irq restore

From	Jiri Slaby <jslaby@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [patch] tty: amiserial.c: remove a double irq restore
Date	2016-08-04 08:30 +0200
Message-ID	<s2kkh-5bD-3@gated-at.bofh.it> (permalink)
References	<s2kkh-5bD-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/04/2016, 07:34 AM, Dan Carpenter wrote:
> We already called "local_irq_restore(flags);" so this isn't needed.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> index 208f573..2f33cf1 100644
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -880,7 +880,6 @@ static int rs_write(struct tty_struct * tty, const unsigned char *buf, int count

If I add a bit more context:

                local_irq_disable();
                custom.intena = IF_SETCLR | IF_TBE;
                mb();
>  		/* set a pending Tx Interrupt, transmitter should restart now */
>  		custom.intreq = IF_SETCLR | IF_TBE;
>  		mb();
> -		local_irq_restore(flags);

Really?

thanks,
-- 
js
suse labs

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [patch] tty: amiserial.c: remove a double irq restore Jiri Slaby <jslaby@suse.cz> - 2016-08-04 08:30 +0200
  Re: [patch] tty: amiserial.c: remove a double irq restore Dan Carpenter <dan.carpenter@oracle.com> - 2016-08-04 12:20 +0200

csiph-web