Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1456190

[patch] tty: amiserial.c: remove a double irq restore

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject [patch] tty: amiserial.c: remove a double irq restore
Date 2016-08-04 08:40 +0200
Message-ID <s2kkh-5bD-5@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


We already called "local_irq_restore(flags);" so this isn't needed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
index 208f573..2f33cf1 100644
--- a/drivers/tty/amiserial.c
+++ b/drivers/tty/amiserial.c
@@ -880,7 +880,6 @@ static int rs_write(struct tty_struct * tty, const unsigned char *buf, int count
 		/* set a pending Tx Interrupt, transmitter should restart now */
 		custom.intreq = IF_SETCLR | IF_TBE;
 		mb();
-		local_irq_restore(flags);
 	}
 	return ret;
 }

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[patch] tty: amiserial.c: remove a double irq restore Dan Carpenter <dan.carpenter@oracle.com> - 2016-08-04 08:40 +0200

csiph-web