Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1400097

Re: [PATCH] pinctrl: stm32: Implement .pin_config_dbg_show()

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] pinctrl: stm32: Implement .pin_config_dbg_show()
Date 2016-05-12 15:50 +0200
Message-ID <rxZa2-70E-5@gated-at.bofh.it> (permalink)
References <rthAB-7vA-15@gated-at.bofh.it> <rxeuu-1FZ-35@gated-at.bofh.it> <rxZa2-70E-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, May 11, 2016 at 3:40 PM, Patrice Chotard <patrice.chotard@st.com> wrote:
> On 05/10/2016 01:50 PM, Linus Walleij wrote:

> Sorry i didn't pay attention, but there is a compilation warning in this
> patch.
>
> drivers/pinctrl/stm32/pinctrl-stm32.c:823:7: warning: too many arguments for
> format [-Wformat-extra-args]
>        speeds[speed], "speed");
>
>
> What do you prefer ?
>  _ me to submit a v2 fixing this warning and at the same occasion include
> the requested code factorization
>  _ or submit additionnal patchset ?

Just send a patch on top fixing this.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: stm32: Implement .pin_config_dbg_show() <patrice.chotard@st.com> - 2016-04-29 16:30 +0200
  Re: [PATCH] pinctrl: stm32: Implement .pin_config_dbg_show() Linus Walleij <linus.walleij@linaro.org> - 2016-05-10 14:00 +0200
    Re: [PATCH] pinctrl: stm32: Implement .pin_config_dbg_show() Patrice Chotard <patrice.chotard@st.com> - 2016-05-10 14:10 +0200
    Re: [PATCH] pinctrl: stm32: Implement .pin_config_dbg_show() Linus Walleij <linus.walleij@linaro.org> - 2016-05-12 15:50 +0200
      Re: [PATCH] pinctrl: stm32: Implement .pin_config_dbg_show() Patrice Chotard <patrice.chotard@st.com> - 2016-05-12 16:50 +0200

csiph-web