Re: [PATCH] pinctrl: stm32: Implement .pin_config_dbg_show()

Path	csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: stm32: Implement .pin_config_dbg_show()
Date	Thu, 12 May 2016 15:50:02 +0200
Message-ID	<rxZa2-70E-5@gated-at.bofh.it> (permalink)
References	<rthAB-7vA-15@gated-at.bofh.it> <rxeuu-1FZ-35@gated-at.bofh.it> <rxZa2-70E-7@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=0eAnsKHS8UelICTX11ol+sVnFIKiAitsp0NxsUQmRXw=; b=aGexaBu9DrSJ6a7JdiSkQExIag8OceOtAL+BRIVuOQ+Sz9rrOqiZZL/UojQcURVhkm 8kqzBx+3vjtDikcBedycJHcedfzunEasXNuAcu1HlvJ4ZNAsyRD37IK732+zXk3ywm48 /4gBV7L3bBQZbmqs4SuKvZ93UwdZUOFxlDLq8=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=0eAnsKHS8UelICTX11ol+sVnFIKiAitsp0NxsUQmRXw=; b=meXwWVjlrYQb8Yd6xgLe8SEoDSRIpsIm9PPB3/kmDkPKfjZ86etm8zQhwEcT3ETL/G EewhhHtI4u9UBfp6Bal+yOGetJNismLPQPPjFb3kA5rnx5o5WXXR7nZAhFBUKymhl+HS yZDXKm+4naGLYK1lN7DvXLJpqgJaF+jTndXhCGYc8Kkkn/qyYIdn3fEMJv8AE10Q2jY3 GAnRl91s2lRBHB8KM9qnES6NLXoSIM1DvVtxIHJDNyoYV9YjVKm6tw/N+ltAtgx1/sFc r/uqS8zOrVkRrLENHTtf4H4oKh8Xa8UUA9bJsIhyMXRiqoZ9s+ruY8pL1CeOrX1GzLNh ebGA==
X-Gm-Message-State	AOPr4FUJ/Ve2LhqGb4ttH6U4LKUANLkmtv8KTp36ZN384BBVPi9MDmAi+s2Et5il6HDS8/6CCYNrjlK4vcjxa0xG
MIME-Version	1.0
X-Received	by 10.202.187.212 with SMTP id l203mr5477894oif.53.1463060438683; Thu, 12 May 2016 06:40:38 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	20
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Maxime Coquelin <mcoquelin.stm32@gmail.com>
X-Original-Date	Thu, 12 May 2016 15:40:38 +0200
X-Original-Message-ID	<CACRpkdawoqfqN8YeojyrzPru2fwrFMidc1e2v7yxHRpPf+rK6w@mail.gmail.com>
X-Original-References	<1461939943-24752-1-git-send-email-patrice.chotard@st.com> <CACRpkdZ=KsPL1mBS1bLi=jYsv=Vb1QNBi8XPAJW50doPcwBuZg@mail.gmail.com> <5733364A.3090606@st.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1400097

Show key headers only | View raw

On Wed, May 11, 2016 at 3:40 PM, Patrice Chotard <patrice.chotard@st.com> wrote:
> On 05/10/2016 01:50 PM, Linus Walleij wrote:

> Sorry i didn't pay attention, but there is a compilation warning in this
> patch.
>
> drivers/pinctrl/stm32/pinctrl-stm32.c:823:7: warning: too many arguments for
> format [-Wformat-extra-args]
>        speeds[speed], "speed");
>
>
> What do you prefer ?
>  _ me to submit a v2 fixing this warning and at the same occasion include
> the requested code factorization
>  _ or submit additionnal patchset ?

Just send a patch on top fixing this.

Yours,
Linus Walleij

Thread

[PATCH] pinctrl: stm32: Implement .pin_config_dbg_show() <patrice.chotard@st.com> - 2016-04-29 16:30 +0200
  Re: [PATCH] pinctrl: stm32: Implement .pin_config_dbg_show() Linus Walleij <linus.walleij@linaro.org> - 2016-05-10 14:00 +0200
    Re: [PATCH] pinctrl: stm32: Implement .pin_config_dbg_show() Patrice Chotard <patrice.chotard@st.com> - 2016-05-10 14:10 +0200
    Re: [PATCH] pinctrl: stm32: Implement .pin_config_dbg_show() Linus Walleij <linus.walleij@linaro.org> - 2016-05-12 15:50 +0200
      Re: [PATCH] pinctrl: stm32: Implement .pin_config_dbg_show() Patrice Chotard <patrice.chotard@st.com> - 2016-05-12 16:50 +0200

csiph-web