Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1399511

[PATCH v7 6/6] dax: fix a comment in dax_zero_page_range and dax_truncate_page

Show all headers | View raw

The distinction between PAGE_SIZE and PAGE_CACHE_SIZE was removed in

09cbfea mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release}
macros

The comments for the above functions described a distinction between
those, that is now redundant, so remove those paragraphs

Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
 fs/dax.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/fs/dax.c b/fs/dax.c
index 0b9a169..ea936b3 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -995,12 +995,6 @@ EXPORT_SYMBOL_GPL(__dax_zero_page_range);
  * page in a DAX file.  This is intended for hole-punch operations.  If
  * you are truncating a file, the helper function dax_truncate_page() may be
  * more convenient.
- *
- * We work in terms of PAGE_SIZE here for commonality with
- * block_truncate_page(), but we could go down to PAGE_SIZE if the filesystem
- * took care of disposing of the unnecessary blocks.  Even if the filesystem
- * block size is smaller than PAGE_SIZE, we have to zero the rest of the page
- * since the file might be mmapped.
  */
 int dax_zero_page_range(struct inode *inode, loff_t from, unsigned length,
 							get_block_t get_block)
@@ -1035,12 +1029,6 @@ EXPORT_SYMBOL_GPL(dax_zero_page_range);
  *
  * Similar to block_truncate_page(), this function can be called by a
  * filesystem when it is truncating a DAX file to handle the partial page.
- *
- * We work in terms of PAGE_SIZE here for commonality with
- * block_truncate_page(), but we could go down to PAGE_SIZE if the filesystem
- * took care of disposing of the unnecessary blocks.  Even if the filesystem
- * block size is smaller than PAGE_SIZE, we have to zero the rest of the page
- * since the file might be mmapped.
  */
 int dax_truncate_page(struct inode *inode, loff_t from, get_block_t get_block)
 {
-- 
2.5.5

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/6] dax: handling media errors (clear-on-zero only) Vishal Verma <vishal.l.verma@intel.com> - 2016-05-11 23:10 +0200
  [PATCH v7 6/6] dax: fix a comment in dax_zero_page_range and dax_truncate_page Vishal Verma <vishal.l.verma@intel.com> - 2016-05-11 23:10 +0200
  [PATCH v7 2/6] dax: enable dax in the presence of known media errors (badblocks) Vishal Verma <vishal.l.verma@intel.com> - 2016-05-11 23:20 +0200
  [PATCH v7 3/6] dax: use sb_issue_zerout instead of calling dax_clear_sectors Vishal Verma <vishal.l.verma@intel.com> - 2016-05-11 23:20 +0200
  [PATCH v7 4/6] dax: export a low-level __dax_zero_page_range helper Vishal Verma <vishal.l.verma@intel.com> - 2016-05-11 23:20 +0200
    Re: [PATCH v7 4/6] dax: export a low-level __dax_zero_page_range  helper Jan Kara <jack@suse.cz> - 2016-05-12 10:50 +0200
      Re: [PATCH v7 4/6] dax: export a low-level __dax_zero_page_range  helper "Verma, Vishal L" <vishal.l.verma@intel.com> - 2016-05-12 19:10 +0200
  [PATCH v7 5/6] dax: for truncate/hole-punch, do zeroing through the driver if possible Vishal Verma <vishal.l.verma@intel.com> - 2016-05-11 23:20 +0200
    Re: [PATCH v7 5/6] dax: for truncate/hole-punch, do zeroing through  the driver if possible Jan Kara <jack@suse.cz> - 2016-05-12 10:40 +0200

csiph-web