Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1399749

Re: [PATCH v7 5/6] dax: for truncate/hole-punch, do zeroing through the driver if possible

Show all headers | View raw

On Wed 11-05-16 15:08:51, Vishal Verma wrote:
> In the truncate or hole-punch path in dax, we clear out sub-page ranges.
> If these sub-page ranges are sector aligned and sized, we can do the
> zeroing through the driver instead so that error-clearing is handled
> automatically.
> 
> For sub-sector ranges, we still have to rely on clear_pmem and have the
> possibility of tripping over errors.
> 
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> Cc: Jeff Moyer <jmoyer@redhat.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: Dave Chinner <david@fromorbit.com>
> Cc: Jan Kara <jack@suse.cz>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>

The patch looks good to me now. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/6] dax: handling media errors (clear-on-zero only) Vishal Verma <vishal.l.verma@intel.com> - 2016-05-11 23:10 +0200
  [PATCH v7 6/6] dax: fix a comment in dax_zero_page_range and dax_truncate_page Vishal Verma <vishal.l.verma@intel.com> - 2016-05-11 23:10 +0200
  [PATCH v7 2/6] dax: enable dax in the presence of known media errors (badblocks) Vishal Verma <vishal.l.verma@intel.com> - 2016-05-11 23:20 +0200
  [PATCH v7 3/6] dax: use sb_issue_zerout instead of calling dax_clear_sectors Vishal Verma <vishal.l.verma@intel.com> - 2016-05-11 23:20 +0200
  [PATCH v7 4/6] dax: export a low-level __dax_zero_page_range helper Vishal Verma <vishal.l.verma@intel.com> - 2016-05-11 23:20 +0200
    Re: [PATCH v7 4/6] dax: export a low-level __dax_zero_page_range  helper Jan Kara <jack@suse.cz> - 2016-05-12 10:50 +0200
      Re: [PATCH v7 4/6] dax: export a low-level __dax_zero_page_range  helper "Verma, Vishal L" <vishal.l.verma@intel.com> - 2016-05-12 19:10 +0200
  [PATCH v7 5/6] dax: for truncate/hole-punch, do zeroing through the driver if possible Vishal Verma <vishal.l.verma@intel.com> - 2016-05-11 23:20 +0200
    Re: [PATCH v7 5/6] dax: for truncate/hole-punch, do zeroing through  the driver if possible Jan Kara <jack@suse.cz> - 2016-05-12 10:40 +0200

csiph-web