Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1399485

[PATCH] drm: mediatek: remove IOMMU_DMA select

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject [PATCH] drm: mediatek: remove IOMMU_DMA select
Date 2016-05-11 22:20 +0200
Message-ID <rxILT-7dz-1@gated-at.bofh.it> (permalink)
References <rxERX-3dg-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


We get a harmless build warning when trying to use the mediatek
DRM driver with IOMMU support disabled:

warning: (DRM_MEDIATEK) selects IOMMU_DMA which has unmet direct dependencies (IOMMU_SUPPORT)

However, the IOMMU_DMA symbol is not meant to be used by drivers
at all, and this driver doesn't seem to have a strict dependency
on it other than using the mediatek IOMMU driver that does.

Since we also want to be able to do compile tests with the
driver on other platforms, the IOMMU_DMA symbol should not
be selected here.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
If someone has a better explanation about why the 'select' is here,
let me know, it certainly seems out of place.

 drivers/gpu/drm/mediatek/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
index 0c06a69d7f04..545973f6b743 100644
--- a/drivers/gpu/drm/mediatek/Kconfig
+++ b/drivers/gpu/drm/mediatek/Kconfig
@@ -7,7 +7,6 @@ config DRM_MEDIATEK
 	select DRM_KMS_HELPER
 	select DRM_MIPI_DSI
 	select DRM_PANEL
-	select IOMMU_DMA
 	select MEMORY
 	select MTK_SMI
 	help
-- 
2.7.0

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

More build fixes for omapdrm in current -next Arnd Bergmann <arnd@arndb.de> - 2016-05-11 18:10 +0200
  [PATCH 1/3] drm/omap: include linux/seq_file.h where needed Arnd Bergmann <arnd@arndb.de> - 2016-05-11 18:10 +0200
  [PATCH 2/3] drm/omap: include linux/of.h where needed Arnd Bergmann <arnd@arndb.de> - 2016-05-11 18:10 +0200
  [PATCH] drm: mediatek: remove IOMMU_DMA select Arnd Bergmann <arnd@arndb.de> - 2016-05-11 22:20 +0200
    Re: [PATCH] drm: mediatek: remove IOMMU_DMA select Arnd Bergmann <arnd@arndb.de> - 2016-05-11 22:20 +0200
    Re: [PATCH] drm: mediatek: remove IOMMU_DMA select Robin Murphy <robin.murphy@arm.com> - 2016-05-12 11:30 +0200
    Re: [PATCH] drm: mediatek: remove IOMMU_DMA select Philipp Zabel <p.zabel@pengutronix.de> - 2016-05-12 12:50 +0200

csiph-web