Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1399489

Re: [PATCH] drm: mediatek: remove IOMMU_DMA select

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH] drm: mediatek: remove IOMMU_DMA select
Date 2016-05-11 22:20 +0200
Message-ID <rxILU-7dz-7@gated-at.bofh.it> (permalink)
References <rxERX-3dg-3@gated-at.bofh.it> <rxILT-7dz-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wednesday 11 May 2016 22:11:07 Arnd Bergmann wrote:
> We get a harmless build warning when trying to use the mediatek
> DRM driver with IOMMU support disabled:
> 
> warning: (DRM_MEDIATEK) selects IOMMU_DMA which has unmet direct dependencies (IOMMU_SUPPORT)
> 
> However, the IOMMU_DMA symbol is not meant to be used by drivers
> at all, and this driver doesn't seem to have a strict dependency
> on it other than using the mediatek IOMMU driver that does.
> 
> Since we also want to be able to do compile tests with the
> driver on other platforms, the IOMMU_DMA symbol should not
> be selected here.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> If someone has a better explanation about why the 'select' is here,
> let me know, it certainly seems out of place.

Sorry, I didn't mean to send this as a reply to "More build fixes for
omapdrm in current -next", I copied the wrong command line.

I'll resend it if necessary.

	Arnd

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

More build fixes for omapdrm in current -next Arnd Bergmann <arnd@arndb.de> - 2016-05-11 18:10 +0200
  [PATCH 1/3] drm/omap: include linux/seq_file.h where needed Arnd Bergmann <arnd@arndb.de> - 2016-05-11 18:10 +0200
  [PATCH 2/3] drm/omap: include linux/of.h where needed Arnd Bergmann <arnd@arndb.de> - 2016-05-11 18:10 +0200
  [PATCH] drm: mediatek: remove IOMMU_DMA select Arnd Bergmann <arnd@arndb.de> - 2016-05-11 22:20 +0200
    Re: [PATCH] drm: mediatek: remove IOMMU_DMA select Arnd Bergmann <arnd@arndb.de> - 2016-05-11 22:20 +0200
    Re: [PATCH] drm: mediatek: remove IOMMU_DMA select Robin Murphy <robin.murphy@arm.com> - 2016-05-12 11:30 +0200
    Re: [PATCH] drm: mediatek: remove IOMMU_DMA select Philipp Zabel <p.zabel@pengutronix.de> - 2016-05-12 12:50 +0200

csiph-web