Re: [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board
Date	2016-05-11 21:00 +0200
Message-ID	<rxHwu-5FD-1@gated-at.bofh.it> (permalink)
References	<rxwro-3gT-27@gated-at.bofh.it> <rxH3s-5o7-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 11, 2016 at 07:18:31PM +0100, Matthew Leach wrote:
> Hi Krzysztof,
> 
> Sorry for not acting on the feedback sooner - I lost the email in my
> Inbox!
> 
> I've tested the patch on my Origen board and it works fine.  One small
> comment in-line.
> 
> Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:
> 
> > From: Matthew Leach <matthew@mattleach.net>
> >
> > Enable the Origen's usb phy and ohci devices in the device tree.  Also
> > add the "samsung,vbus-gpio" property to enable the GPX3(5) gpio pin so
> > the AX88760 hub is powered.
> >
> > Signed-off-by: Matthew Leach <matthew@mattleach.net>
> > [k.kozlowski: Extend nodes by label notation instead of path]
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> >  arch/arm/boot/dts/exynos4412-origen.dts | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
> > index 8bca699b7f20..4c59bdb0e6f3 100644
> > --- a/arch/arm/boot/dts/exynos4412-origen.dts
> > +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> > @@ -77,12 +77,29 @@
> >  			clock-frequency = <24000000>;
> >  		};
> >  	};
> > +
> 
> I think we could loose this line break?

Yeah, that slipped through my fingers.

Thanks for testing,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-11 09:10 +0200
  Re: [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board Matthew Leach <matthew@mattleach.net> - 2016-05-11 20:30 +0200
    Re: [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-11 21:00 +0200

csiph-web