Re: [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board
Date	Wed, 11 May 2016 21:00:02 +0200
Message-ID	<rxHwu-5FD-1@gated-at.bofh.it> (permalink)
References	<rxwro-3gT-27@gated-at.bofh.it> <rxH3s-5o7-17@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CjDZYqfy4fDqujv5rgEuIbFG9PNW7T1pkBMa5qmUs4Y=; b=UbYFgF2EbIn7E8j/41RNfMifVLkXgGWjSy/o7YJ5O4/Wg+Jhfb4Hzuf5YMgMlYhMeT IlWHM4cF5fTBRUC3stg4ZiA10f7vK39R2oAR1fEgUAcgZuoRCegJTCRrHKH5RhNzCgyJ 0FAWRwqZ//S+9+QelTIQtw82FdQlsStR5HtdjEgFA5hdvaRn6e5Ee+Ke5X/XB0DwG+8L dFkC8QHohYfNqRBpG7+rH1MUFOvVc/jDa8XoU8QiZe/Smf+TXo1cWjurTuQT4nW8Ldjq HfvYWrErG+Xd3nYq1AM6dO3qr9oHS7kejf/4xugdtPg5ifjSE4q6P75z9TH9ZthtAFm4 LnPw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=CjDZYqfy4fDqujv5rgEuIbFG9PNW7T1pkBMa5qmUs4Y=; b=WJZZe2w6CHWonnOn/42G7x7hgYXruVcZW4d3MmwwvVSTqb4atdfQUMI2udWvOu61Ey DJ4kkcnTAKz6y54PoNnTjHmZNXCzIRDQT+S+Jl98wongA/THSvXTOkm96Vni7BncjafC H0SGHHYAv40CZeYOWiez7XiC0n+OJ/nWGdErg7GcZXIt+yvDsoVSQ8XUv7p2UnjnwEqb KtqMs2nE/rAZncVLkuqzo0ltsySjb+iZe+dzU0FFjv+LznAoQqotyJVdjxQvTt5PBPPs isZLR6dpj1wI0E1yft+n4kW1b3Dcu7lcylSodKbFJ7vLrKm5R/2hm2mND9euETCXkC8Z soqw==
X-Gm-Message-State	AOPr4FV/Tq1Ir9xhy0kQydPBlc8B16sif8aFf/DlItRNRbznlnmtrT1klScRdpWF4Vsl8g==
X-Received	by 10.25.42.197 with SMTP id q188mr2348755lfq.2.1462992821433; Wed, 11 May 2016 11:53:41 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	Krzysztof Kozlowski <k.kozlowski@samsung.com>, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, linux-kernel@vger.kernel.org, Kukjin Kim <kgene@kernel.org>, linux-arm-kernel@lists.infradead.org
X-Original-Date	Wed, 11 May 2016 20:53:38 +0200
X-Original-Message-ID	<20160511185338.GA10164@kozik-lap>
X-Original-References	<1462950412-16681-1-git-send-email-k.kozlowski@samsung.com> <87y47gwj9k.fsf@mattleach.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1399420

Show key headers only | View raw

On Wed, May 11, 2016 at 07:18:31PM +0100, Matthew Leach wrote:
> Hi Krzysztof,
> 
> Sorry for not acting on the feedback sooner - I lost the email in my
> Inbox!
> 
> I've tested the patch on my Origen board and it works fine.  One small
> comment in-line.
> 
> Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:
> 
> > From: Matthew Leach <matthew@mattleach.net>
> >
> > Enable the Origen's usb phy and ohci devices in the device tree.  Also
> > add the "samsung,vbus-gpio" property to enable the GPX3(5) gpio pin so
> > the AX88760 hub is powered.
> >
> > Signed-off-by: Matthew Leach <matthew@mattleach.net>
> > [k.kozlowski: Extend nodes by label notation instead of path]
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> >  arch/arm/boot/dts/exynos4412-origen.dts | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
> > index 8bca699b7f20..4c59bdb0e6f3 100644
> > --- a/arch/arm/boot/dts/exynos4412-origen.dts
> > +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> > @@ -77,12 +77,29 @@
> >  			clock-frequency = <24000000>;
> >  		};
> >  	};
> > +
> 
> I think we could loose this line break?

Yeah, that slipped through my fingers.

Thanks for testing,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-11 09:10 +0200
  Re: [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board Matthew Leach <matthew@mattleach.net> - 2016-05-11 20:30 +0200
    Re: [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-11 21:00 +0200

csiph-web