Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1399418

Re: [PATCH v6 4/5] dax: for truncate/hole-punch, do zeroing through the driver if possible

Show all headers | View raw

On Tue, 2016-05-10 at 12:49 -0600, Vishal Verma wrote:
> 
...

> @@ -1240,11 +1254,16 @@ int dax_zero_page_range(struct inode *inode,
> loff_t from, unsigned length,
>  			.size = PAGE_SIZE,
>  		};
>  
> -		if (dax_map_atomic(bdev, &dax) < 0)
> -			return PTR_ERR(dax.addr);
> -		clear_pmem(dax.addr + offset, length);
> -		wmb_pmem();
> -		dax_unmap_atomic(bdev, &dax);
> +		if (dax_range_is_aligned(bdev, &dax, offset, length))
> +			return blkdev_issue_zeroout(bdev, dax.sector,
> +					length >> 9, GFP_NOFS, true);

Found another bug here while testing. The zeroout needs to be done for
sector + (offset >> 9). The above just zeroed out the first sector of
the page irrespective of offset, which is wrong.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/5] dax: handling media errors (clear-on-zero only) Vishal Verma <vishal.l.verma@intel.com> - 2016-05-10 21:00 +0200
  [PATCH v6 4/5] dax: for truncate/hole-punch, do zeroing through the driver if possible Vishal Verma <vishal.l.verma@intel.com> - 2016-05-10 21:00 +0200
    Re: [PATCH v6 4/5] dax: for truncate/hole-punch, do zeroing through  the driver if possible Christoph Hellwig <hch@infradead.org> - 2016-05-10 21:30 +0200
      Re: [PATCH v6 4/5] dax: for truncate/hole-punch, do zeroing through  the driver if possible "Verma, Vishal L" <vishal.l.verma@intel.com> - 2016-05-10 21:50 +0200
    Re: [PATCH v6 4/5] dax: for truncate/hole-punch, do zeroing through  the driver if possible Jan Kara <jack@suse.cz> - 2016-05-11 10:20 +0200
      Re: [PATCH v6 4/5] dax: for truncate/hole-punch, do zeroing through  the driver if possible "Verma, Vishal L" <vishal.l.verma@intel.com> - 2016-05-11 19:50 +0200
    Re: [PATCH v6 4/5] dax: for truncate/hole-punch, do zeroing through  the driver if possible "Verma, Vishal L" <vishal.l.verma@intel.com> - 2016-05-11 20:50 +0200
  [PATCH v6 2/5] dax: enable dax in the presence of known media errors (badblocks) Vishal Verma <vishal.l.verma@intel.com> - 2016-05-10 21:00 +0200
  [PATCH v6 5/5] dax: fix a comment in dax_zero_page_range and dax_truncate_page Vishal Verma <vishal.l.verma@intel.com> - 2016-05-10 21:00 +0200
  [PATCH v6 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors Vishal Verma <vishal.l.verma@intel.com> - 2016-05-10 21:00 +0200

csiph-web