Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1399389

Re: [PATCH v6 4/5] dax: for truncate/hole-punch, do zeroing through the driver if possible

Show all headers | View raw

On Wed, 2016-05-11 at 10:15 +0200, Jan Kara wrote:
> On Tue 10-05-16 12:49:15, Vishal Verma wrote:
> > 
> > In the truncate or hole-punch path in dax, we clear out sub-page
> > ranges.
> > If these sub-page ranges are sector aligned and sized, we can do the
> > zeroing through the driver instead so that error-clearing is handled
> > automatically.
> > 
> > For sub-sector ranges, we still have to rely on clear_pmem and have
> > the
> > possibility of tripping over errors.
> > 
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> > Cc: Jeff Moyer <jmoyer@redhat.com>
> > Cc: Christoph Hellwig <hch@infradead.org>
> > Cc: Dave Chinner <david@fromorbit.com>
> > Cc: Jan Kara <jack@suse.cz>
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ...
> 
> > 
> > +static bool dax_range_is_aligned(struct block_device *bdev,
> > +				 struct blk_dax_ctl *dax, unsigned
> > int offset,
> > +				 unsigned int length)
> > +{
> > +	unsigned short sector_size = bdev_logical_block_size(bdev);
> > +
> > +	if (!IS_ALIGNED(((u64)dax->addr + offset), sector_size))
> One more question: 'dax' is initialized in dax_zero_page_range() and
> dax->addr is going to be always NULL here. So either you forgot to
> call
> dax_map_atomic() to get the addr or the use of dax->addr is just bogus
> (which is what I currently believe since I see no way how the address
> could
> be unaligned with the sector_size)...
> 

Good catch, and you're right. I don't think I actually even want to use
dax->addr for the alignment check here - I want to check if we're
aligned to the block device sector. I'm thinking something like:

	if (!IS_ALIGNED(offset, sector_size))

Technically we want to check if sector * sector_size + offset is
aligned, but the first part of that is already a sector :)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/5] dax: handling media errors (clear-on-zero only) Vishal Verma <vishal.l.verma@intel.com> - 2016-05-10 21:00 +0200
  [PATCH v6 4/5] dax: for truncate/hole-punch, do zeroing through the driver if possible Vishal Verma <vishal.l.verma@intel.com> - 2016-05-10 21:00 +0200
    Re: [PATCH v6 4/5] dax: for truncate/hole-punch, do zeroing through  the driver if possible Christoph Hellwig <hch@infradead.org> - 2016-05-10 21:30 +0200
      Re: [PATCH v6 4/5] dax: for truncate/hole-punch, do zeroing through  the driver if possible "Verma, Vishal L" <vishal.l.verma@intel.com> - 2016-05-10 21:50 +0200
    Re: [PATCH v6 4/5] dax: for truncate/hole-punch, do zeroing through  the driver if possible Jan Kara <jack@suse.cz> - 2016-05-11 10:20 +0200
      Re: [PATCH v6 4/5] dax: for truncate/hole-punch, do zeroing through  the driver if possible "Verma, Vishal L" <vishal.l.verma@intel.com> - 2016-05-11 19:50 +0200
    Re: [PATCH v6 4/5] dax: for truncate/hole-punch, do zeroing through  the driver if possible "Verma, Vishal L" <vishal.l.verma@intel.com> - 2016-05-11 20:50 +0200
  [PATCH v6 2/5] dax: enable dax in the presence of known media errors (badblocks) Vishal Verma <vishal.l.verma@intel.com> - 2016-05-10 21:00 +0200
  [PATCH v6 5/5] dax: fix a comment in dax_zero_page_range and dax_truncate_page Vishal Verma <vishal.l.verma@intel.com> - 2016-05-10 21:00 +0200
  [PATCH v6 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors Vishal Verma <vishal.l.verma@intel.com> - 2016-05-10 21:00 +0200

csiph-web