Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1396668

[PATCH 3/7] tty: cyclades+mxser, do not initialize to zero

From Jiri Slaby <jslaby@suse.cz>
Newsgroups linux.kernel
Subject [PATCH 3/7] tty: cyclades+mxser, do not initialize to zero
Date 2016-05-09 09:20 +0200
Message-ID <rwNE0-8jo-63@gated-at.bofh.it> (permalink)
References <rwNDY-8jo-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Do not initialize members of initialized structures to zero. They are
zeroed automatically.

Part of hub6 cleanup series.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
 drivers/tty/cyclades.c | 1 -
 drivers/tty/mxser.c    | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/tty/cyclades.c b/drivers/tty/cyclades.c
index 2943d6ff54df..7251430bf149 100644
--- a/drivers/tty/cyclades.c
+++ b/drivers/tty/cyclades.c
@@ -2288,7 +2288,6 @@ static int cy_get_serial_info(struct cyclades_port *info,
 		.closing_wait = info->port.closing_wait,
 		.baud_base = info->baud,
 		.custom_divisor = info->custom_divisor,
-		.hub6 = 0,		/*!!! */
 	};
 	return copy_to_user(retinfo, &tmp, sizeof(*retinfo)) ? -EFAULT : 0;
 }
diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
index ebb8c0034101..2ff280d8045a 100644
--- a/drivers/tty/mxser.c
+++ b/drivers/tty/mxser.c
@@ -1219,7 +1219,6 @@ static int mxser_get_serial_info(struct tty_struct *tty,
 		.close_delay = info->port.close_delay,
 		.closing_wait = info->port.closing_wait,
 		.custom_divisor = info->custom_divisor,
-		.hub6 = 0
 	};
 	if (copy_to_user(retinfo, &tmp, sizeof(*retinfo)))
 		return -EFAULT;
-- 
2.8.2

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/7] tty: ipwireless, cleanup TIOCGSERIAL Jiri Slaby <jslaby@suse.cz> - 2016-05-09 09:20 +0200
  [PATCH 5/7] tty: stop defining STD_COM_FLAGS in drivers Jiri Slaby <jslaby@suse.cz> - 2016-05-09 09:20 +0200
  [PATCH 2/7] net: ircomm, cleanup TIOCGSERIAL Jiri Slaby <jslaby@suse.cz> - 2016-05-09 09:20 +0200
    Re: [PATCH 2/7] net: ircomm, cleanup TIOCGSERIAL David Miller <davem@davemloft.net> - 2016-05-10 20:20 +0200
  [PATCH 6/7] tty: 8250, drop unused members from struct old_serial_port Jiri Slaby <jslaby@suse.cz> - 2016-05-09 09:20 +0200
  [PATCH 7/7] tty: 8250, kill DEBUG_INTR Jiri Slaby <jslaby@suse.cz> - 2016-05-09 09:20 +0200
  [PATCH 4/7] tty: frv, remove unused serial macros Jiri Slaby <jslaby@suse.cz> - 2016-05-09 09:20 +0200
  [PATCH 3/7] tty: cyclades+mxser, do not initialize to zero Jiri Slaby <jslaby@suse.cz> - 2016-05-09 09:20 +0200
  Re: [PATCH 1/7] tty: ipwireless, cleanup TIOCGSERIAL David Sterba <dsterba@suse.cz> - 2016-05-09 09:40 +0200

csiph-web