Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1398377

Re: [PATCH 2/7] net: ircomm, cleanup TIOCGSERIAL

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH 2/7] net: ircomm, cleanup TIOCGSERIAL
Date 2016-05-10 20:20 +0200
Message-ID <rxkqe-860-17@gated-at.bofh.it> (permalink)
References <rwNDY-8jo-13@gated-at.bofh.it> <rwNDY-8jo-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Jiri Slaby <jslaby@suse.cz>
Date: Mon,  9 May 2016 09:11:54 +0200

> In ircomm_tty_get_serial_info, struct serial_struct is memset to 0 and
> then some members set to 0 explicitly.
> 
> Remove the latter as it is obviously superfluous.
> 
> And remove the retinfo check against NULL. copy_to_user will take care
> of that.
> 
> Part of hub6 cleanup series.
> 
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>

Acked-by: David S. Miller <davem@davemloft.net>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/7] tty: ipwireless, cleanup TIOCGSERIAL Jiri Slaby <jslaby@suse.cz> - 2016-05-09 09:20 +0200
  [PATCH 5/7] tty: stop defining STD_COM_FLAGS in drivers Jiri Slaby <jslaby@suse.cz> - 2016-05-09 09:20 +0200
  [PATCH 2/7] net: ircomm, cleanup TIOCGSERIAL Jiri Slaby <jslaby@suse.cz> - 2016-05-09 09:20 +0200
    Re: [PATCH 2/7] net: ircomm, cleanup TIOCGSERIAL David Miller <davem@davemloft.net> - 2016-05-10 20:20 +0200
  [PATCH 6/7] tty: 8250, drop unused members from struct old_serial_port Jiri Slaby <jslaby@suse.cz> - 2016-05-09 09:20 +0200
  [PATCH 7/7] tty: 8250, kill DEBUG_INTR Jiri Slaby <jslaby@suse.cz> - 2016-05-09 09:20 +0200
  [PATCH 4/7] tty: frv, remove unused serial macros Jiri Slaby <jslaby@suse.cz> - 2016-05-09 09:20 +0200
  [PATCH 3/7] tty: cyclades+mxser, do not initialize to zero Jiri Slaby <jslaby@suse.cz> - 2016-05-09 09:20 +0200
  Re: [PATCH 1/7] tty: ipwireless, cleanup TIOCGSERIAL David Sterba <dsterba@suse.cz> - 2016-05-09 09:40 +0200

csiph-web