Re: [PATCH v4 10/10] x86/xsaves: Re-enable XSAVES

From	Dave Hansen <dave.hansen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 10/10] x86/xsaves: Re-enable XSAVES
Date	2016-04-29 22:40 +0200
Message-ID	<rtnmG-3LT-11@gated-at.bofh.it> (permalink)
References	<r92ut-2hO-1@gated-at.bofh.it> <r92uv-2hO-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/04/2016 10:12 AM, Yu-cheng Yu wrote:
> We did not handle XSAVES* instructions correctly. There were issues in
> converting between standard and compacted format when interfacing with
> user-space. These issues have been corrected.
> 
> Add a WARN_ONCE() to make it clear that XSAVES supervisor states are not
> yet implemented.

The reason I haven't acked this patch is that I want to be _sure_ that
we've audited all of the call paths that access the XSAVE buffer to
ensure that they can all either handle the XSAVES format *or* don't care
for whatever reason.

Could you share the steps that you've taken to assure yourself that all
of the call paths are handled and we don't have more bugs?

FWIW, this was the single biggest lesson I learned from the failure the
last time this got turned on: we simply didn't go look for all the
places that the new format had to be handled.  Let's be sure we don't
repeat that.

If we get this *wrong* in another user/kernel interface like we did for
ptrace and the signal save/restore and we ever enable a supervisor state
we've got an almost certain immediate root hole of some kind.  I think
we need to exercise some serious caution here.  Thank $DEITY we don't
have any supported supervisor states at the moment.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 10/10] x86/xsaves: Re-enable XSAVES Dave Hansen <dave.hansen@linux.intel.com> - 2016-04-29 22:40 +0200
  Re: [PATCH v4 10/10] x86/xsaves: Re-enable XSAVES Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-04-30 01:20 +0200
    Re: [PATCH v4 10/10] x86/xsaves: Re-enable XSAVES Dave Hansen <dave.hansen@linux.intel.com> - 2016-04-30 02:50 +0200
      Re: [PATCH v4 10/10] x86/xsaves: Re-enable XSAVES Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-05-02 18:20 +0200
        Re: [PATCH v4 10/10] x86/xsaves: Re-enable XSAVES Dave Hansen <dave.hansen@linux.intel.com> - 2016-05-05 00:20 +0200
          Re: [PATCH v4 10/10] x86/xsaves: Re-enable XSAVES Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-05-05 00:30 +0200

csiph-web