Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1391407
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/5] crypto: Use dma_pool_zalloc |
| Date | 2016-04-29 22:40 +0200 |
| Message-ID | <rtnmF-3LT-3@gated-at.bofh.it> (permalink) |
| References | <rtncZ-3HL-5@gated-at.bofh.it> <rtncZ-3HL-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 29 Apr 2016 22:09:11 +0200
Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> Dma_pool_zalloc combines dma_pool_alloc and memset 0. The semantic patch
> that makes this transformation is as follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression d,e;
> statement S;
> @@
>
> d =
> - dma_pool_alloc
> + dma_pool_zalloc
> (...);
> if (!d) S
> - memset(d, 0, sizeof(*d));
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> ---
>
> drivers/crypto/marvell/tdma.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/marvell/tdma.c b/drivers/crypto/marvell/tdma.c
> index 7642798..0ad8f1e 100644
> --- a/drivers/crypto/marvell/tdma.c
> +++ b/drivers/crypto/marvell/tdma.c
> @@ -99,12 +99,11 @@ mv_cesa_dma_add_desc(struct mv_cesa_tdma_chain *chain, gfp_t flags)
> struct mv_cesa_tdma_desc *new_tdma = NULL;
> dma_addr_t dma_handle;
>
> - new_tdma = dma_pool_alloc(cesa_dev->dma->tdma_desc_pool, flags,
> - &dma_handle);
> + new_tdma = dma_pool_zalloc(cesa_dev->dma->tdma_desc_pool, flags,
> + &dma_handle);
> if (!new_tdma)
> return ERR_PTR(-ENOMEM);
>
> - memset(new_tdma, 0, sizeof(*new_tdma));
> new_tdma->cur_dma = dma_handle;
> if (chain->last) {
> chain->last->next_dma = cpu_to_le32(dma_handle);
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 4/5] crypto: Use dma_pool_zalloc Julia Lawall <Julia.Lawall@lip6.fr> - 2016-04-29 22:30 +0200 Re: [PATCH 4/5] crypto: Use dma_pool_zalloc Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-04-29 22:40 +0200 Re: [PATCH 4/5] crypto: Use dma_pool_zalloc Herbert Xu <herbert@gondor.apana.org.au> - 2016-05-03 10:20 +0200
csiph-web