Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1386205

Re: [PATCH RESEND 2/5] USB: serial: cp210x: Made sure SERIAL_XOFF_CONTINUE flag is clear.

Show all headers | View raw

On Sun, Apr 24, 2016 at 12:09:10PM -0500, Konstantin Shkolnyy wrote:
> The CRTCTS flag code intended to clear the SERIAL_XOFF_CONTINUE flag, but
> did it inconsistently. This change is non-functional for existing chips
> because the driver never set the flag and it's clear by default.
> 
> Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>
> ---
>  drivers/usb/serial/cp210x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index de1606f..ede5c52 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -955,7 +955,6 @@ static void cp210x_set_termios(struct tty_struct *tty,
>  			modem_ctl[0] &= ~0x7B;
>  			modem_ctl[0] |= 0x09;
>  			modem_ctl[4] = 0x80;
> -			modem_ctl[7] = 0;
>  			dev_dbg(dev, "%s - flow control = CRTSCTS\n", __func__);
>  		} else {
>  			modem_ctl[0] &= ~0x7B;
> @@ -963,6 +962,7 @@ static void cp210x_set_termios(struct tty_struct *tty,
>  			modem_ctl[4] = 0x40;
>  			dev_dbg(dev, "%s - flow control = NONE\n", __func__);
>  		}
> +		modem_ctl[7] = 0;

I'd rather see this done using bit operations and a define (see my
comments on the next patch).

>  
>  		dev_dbg(dev, "%s - write modem controls = %02x .. .. .. %02x .. .. %02x\n",
>  			__func__, modem_ctl[0], modem_ctl[4], modem_ctl[7]);

Thanks,
Johan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND 2/5] USB: serial: cp210x: Made sure SERIAL_XOFF_CONTINUE flag is clear. Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2016-04-24 19:10 +0200
  Re: [PATCH RESEND 2/5] USB: serial: cp210x: Made sure  SERIAL_XOFF_CONTINUE flag is clear. Johan Hovold <johan@kernel.org> - 2016-04-25 12:20 +0200
  Re: [PATCH RESEND 2/5] USB: serial: cp210x: Made sure  SERIAL_XOFF_CONTINUE flag is clear. Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-25 14:30 +0200

csiph-web