Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1385843 > unrolled thread
| Started by | Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> |
|---|---|
| First post | 2016-04-24 19:10 +0200 |
| Last post | 2016-04-25 14:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH RESEND 2/5] USB: serial: cp210x: Made sure SERIAL_XOFF_CONTINUE flag is clear. Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2016-04-24 19:10 +0200
Re: [PATCH RESEND 2/5] USB: serial: cp210x: Made sure SERIAL_XOFF_CONTINUE flag is clear. Johan Hovold <johan@kernel.org> - 2016-04-25 12:20 +0200
Re: [PATCH RESEND 2/5] USB: serial: cp210x: Made sure SERIAL_XOFF_CONTINUE flag is clear. Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-25 14:30 +0200
| From | Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> |
|---|---|
| Date | 2016-04-24 19:10 +0200 |
| Subject | [PATCH RESEND 2/5] USB: serial: cp210x: Made sure SERIAL_XOFF_CONTINUE flag is clear. |
| Message-ID | <rrvHI-86X-17@gated-at.bofh.it> |
The CRTCTS flag code intended to clear the SERIAL_XOFF_CONTINUE flag, but
did it inconsistently. This change is non-functional for existing chips
because the driver never set the flag and it's clear by default.
Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>
---
drivers/usb/serial/cp210x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index de1606f..ede5c52 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -955,7 +955,6 @@ static void cp210x_set_termios(struct tty_struct *tty,
modem_ctl[0] &= ~0x7B;
modem_ctl[0] |= 0x09;
modem_ctl[4] = 0x80;
- modem_ctl[7] = 0;
dev_dbg(dev, "%s - flow control = CRTSCTS\n", __func__);
} else {
modem_ctl[0] &= ~0x7B;
@@ -963,6 +962,7 @@ static void cp210x_set_termios(struct tty_struct *tty,
modem_ctl[4] = 0x40;
dev_dbg(dev, "%s - flow control = NONE\n", __func__);
}
+ modem_ctl[7] = 0;
dev_dbg(dev, "%s - write modem controls = %02x .. .. .. %02x .. .. %02x\n",
__func__, modem_ctl[0], modem_ctl[4], modem_ctl[7]);
--
1.8.4.5
[toc] | [next] | [standalone]
| From | Johan Hovold <johan@kernel.org> |
|---|---|
| Date | 2016-04-25 12:20 +0200 |
| Subject | Re: [PATCH RESEND 2/5] USB: serial: cp210x: Made sure SERIAL_XOFF_CONTINUE flag is clear. |
| Message-ID | <rrLMu-406-9@gated-at.bofh.it> |
| In reply to | #1385843 |
On Sun, Apr 24, 2016 at 12:09:10PM -0500, Konstantin Shkolnyy wrote:
> The CRTCTS flag code intended to clear the SERIAL_XOFF_CONTINUE flag, but
> did it inconsistently. This change is non-functional for existing chips
> because the driver never set the flag and it's clear by default.
>
> Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>
> ---
> drivers/usb/serial/cp210x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index de1606f..ede5c52 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -955,7 +955,6 @@ static void cp210x_set_termios(struct tty_struct *tty,
> modem_ctl[0] &= ~0x7B;
> modem_ctl[0] |= 0x09;
> modem_ctl[4] = 0x80;
> - modem_ctl[7] = 0;
> dev_dbg(dev, "%s - flow control = CRTSCTS\n", __func__);
> } else {
> modem_ctl[0] &= ~0x7B;
> @@ -963,6 +962,7 @@ static void cp210x_set_termios(struct tty_struct *tty,
> modem_ctl[4] = 0x40;
> dev_dbg(dev, "%s - flow control = NONE\n", __func__);
> }
> + modem_ctl[7] = 0;
I'd rather see this done using bit operations and a define (see my
comments on the next patch).
>
> dev_dbg(dev, "%s - write modem controls = %02x .. .. .. %02x .. .. %02x\n",
> __func__, modem_ctl[0], modem_ctl[4], modem_ctl[7]);
Thanks,
Johan
[toc] | [prev] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2016-04-25 14:30 +0200 |
| Subject | Re: [PATCH RESEND 2/5] USB: serial: cp210x: Made sure SERIAL_XOFF_CONTINUE flag is clear. |
| Message-ID | <rrNOj-5Rt-17@gated-at.bofh.it> |
| In reply to | #1385843 |
Hello.
On 4/24/2016 8:09 PM, Konstantin Shkolnyy wrote:
> The CRTCTS flag code intended to clear the SERIAL_XOFF_CONTINUE flag, but
CRTSCTS? Also, "is" missing before "intended"?
> did it inconsistently. This change is non-functional for existing chips
> because the driver never set the flag and it's clear by default.
Sets.
> Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>
[...]
MBR, Sergei
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web