Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1380469

Re: [PATCHv2]brd: set max_discard_sectors properly

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCHv2]brd: set max_discard_sectors properly
Date 2016-04-16 04:00 +0200
Message-ID <ronGG-42G-7@gated-at.bofh.it> (permalink)
References <rocUW-4mc-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> -	blk_queue_max_discard_sectors(brd->brd_queue, UINT_MAX);
> +	blk_queue_max_discard_sectors(brd->brd_queue, UINT_MAX >> 9);

Shouldn't we fix the issue by capping to UINT_MAX >> 9 inside
blk_queue_max_discard_sectors?  That way we'll prevent against having
issues like this in any other driver as well.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCHv2]brd: set max_discard_sectors properly Jinpu Wang <jinpu.wang@profitbricks.com> - 2016-04-15 16:30 +0200
  Re: [PATCHv2]brd: set max_discard_sectors properly Christoph Hellwig <hch@infradead.org> - 2016-04-16 04:00 +0200
    Re: [PATCHv2]brd: set max_discard_sectors properly Jinpu Wang <jinpu.wang@profitbricks.com> - 2016-04-18 10:40 +0200
      Re: [PATCHv2]brd: set max_discard_sectors properly Jinpu Wang <jinpu.wang@profitbricks.com> - 2016-04-18 16:00 +0200

csiph-web