Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1381374
| From | Jinpu Wang <jinpu.wang@profitbricks.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCHv2]brd: set max_discard_sectors properly |
| Date | 2016-04-18 10:40 +0200 |
| Message-ID | <rpcSR-2jV-7@gated-at.bofh.it> (permalink) |
| References | <rocUW-4mc-15@gated-at.bofh.it> <ronGG-42G-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Apr 16, 2016 at 3:50 AM, Christoph Hellwig <hch@infradead.org> wrote: >> - blk_queue_max_discard_sectors(brd->brd_queue, UINT_MAX); >> + blk_queue_max_discard_sectors(brd->brd_queue, UINT_MAX >> 9); > > Shouldn't we fix the issue by capping to UINT_MAX >> 9 inside > blk_queue_max_discard_sectors? That way we'll prevent against having > issues like this in any other driver as well. Thanks Christoph, make sense to me, will rework it to this way. Regards, Jack
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCHv2]brd: set max_discard_sectors properly Christoph Hellwig <hch@infradead.org> - 2016-04-16 04:00 +0200
Re: [PATCHv2]brd: set max_discard_sectors properly Jinpu Wang <jinpu.wang@profitbricks.com> - 2016-04-18 10:40 +0200
Re: [PATCHv2]brd: set max_discard_sectors properly Jinpu Wang <jinpu.wang@profitbricks.com> - 2016-04-18 16:00 +0200
csiph-web