Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1380395
| From | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error |
| Date | 2016-04-16 02:10 +0200 |
| Message-ID | <rolYe-347-23@gated-at.bofh.it> (permalink) |
| References | <rkorE-3JL-11@gated-at.bofh.it> <rlsCT-3LP-33@gated-at.bofh.it> <rltSi-4D1-3@gated-at.bofh.it> <rnDua-1rq-11@gated-at.bofh.it> <rnEzT-2bp-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 04/14, Masahiro Yamada wrote: > > OK, now I notice another problem in my code; > if foo_clk_init() fails for reason [2], > clk_disable() WARN's due to zero enable_count. > > if (WARN_ON(core->enable_count == 0)) > return; > > > > Perhaps, I got screwed up by splitting clock init stuff > into a helper function. Yep! Can't we just split the enable/disable out into another function separate from the clk_get/put part? That would make things more symmetric and avoid this problem. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-05 04:00 +0200
Re: [PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error Stephen Boyd <sboyd@codeaurora.org> - 2016-04-08 02:40 +0200
Re: [PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-08 04:00 +0200
Re: [PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error Stephen Boyd <sboyd@codeaurora.org> - 2016-04-14 02:40 +0200
Re: [PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-14 03:50 +0200
Re: [PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error Stephen Boyd <sboyd@codeaurora.org> - 2016-04-16 02:10 +0200
Re: [PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error Ralf Baechle <ralf@linux-mips.org> - 2016-04-08 12:30 +0200
Re: [PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-08 13:20 +0200
Re: [PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error Stephen Boyd <sboyd@codeaurora.org> - 2016-04-14 02:50 +0200
csiph-web