Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1380336

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

From Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP
Date 2016-04-16 00:20 +0200
Message-ID <rokfL-1FF-9@gated-at.bofh.it> (permalink)
References <roi4k-8kL-51@gated-at.bofh.it> <roinD-ks-13@gated-at.bofh.it> <roj0m-Bj-11@gated-at.bofh.it> <rok66-1C3-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 16/04/2016 at 00:05:08 +0200, Andrew Lunn wrote :
> > Trace without my patch:
> > libphy: MACB_mii_bus: probed
> > macb f8020000.ethernet eth0: Cadence GEM rev 0x00020120 at 0xf8020000 irq 27 (fc:c2:3d:0c:6e:05)
> > Micrel KSZ8081 or KSZ8091 f8020000.etherne:01: attached PHY driver [Micrel KSZ8081 or KSZ8091] (mii_bus:phy_addr=f8020000.etherne:01, irq=171)
> > Micrel KSZ8081 or KSZ8091 f8020000.etherne:01: PHY state change READY -> READY
> > [...]
> > Micrel KSZ8081 or KSZ8091 f8020000.etherne:01: PHY state change READY -> READY
> 
> Are there some state changes before this? How is it getting to state
> READY? It would expect it to start in DOWN, from when the phy device
> was created in phy_device_create().
> 

No other changes. I forgot to mention that this is when booting with a
cable plugged in. Unplugging and replugging the cable makes the link
detection work fine even without the patch.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: phy: Ensure the state machine is called when phy is UP Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-04-15 22:00 +0200
  Re: [PATCH] net: phy: Ensure the state machine is called when phy is  UP Florian Fainelli <f.fainelli@gmail.com> - 2016-04-15 22:20 +0200
    Re: [PATCH] net: phy: Ensure the state machine is called when phy is  UP Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-04-15 23:00 +0200
      Re: [PATCH] net: phy: Ensure the state machine is called when phy is  UP Andrew Lunn <andrew@lunn.ch> - 2016-04-16 00:10 +0200
        Re: [PATCH] net: phy: Ensure the state machine is called when phy is  UP Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-04-16 00:20 +0200
          Re: [PATCH] net: phy: Ensure the state machine is called when phy is  UP Florian Fainelli <f.fainelli@gmail.com> - 2016-04-16 00:30 +0200
            Re: [PATCH] net: phy: Ensure the state machine is called when phy is  UP Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-04-19 00:20 +0200
              Re: [PATCH] net: phy: Ensure the state machine is called when phy is  UP Florian Fainelli <f.fainelli@gmail.com> - 2016-04-19 00:30 +0200
                Re: [PATCH] net: phy: Ensure the state machine is called when phy is  UP Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-04-19 00:50 +0200
          Re: [PATCH] net: phy: Ensure the state machine is called when phy is  UP Andrew Lunn <andrew@lunn.ch> - 2016-04-16 00:40 +0200
            Re: [PATCH] net: phy: Ensure the state machine is called when phy is  UP Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-04-16 00:50 +0200

csiph-web