Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1379836

Re: [PATCH] block: loop: fix filesystem corruption in case of aio/dio

Show all headers | View raw

-------- Forwarded Message --------
Subject: Re: [PATCH] block: loop: fix filesystem corruption in case of aio/dio
Date: Fri, 15 Apr 2016 21:16:42 +0800
From: Ming Lei <ming.lei@canonical.com>
To: Holger Hoffstätte <holger.hoffstaette@googlemail.com>

On Fri, Apr 15, 2016 at 8:51 PM, Holger Hoffstätte
<holger.hoffstaette@googlemail.com> wrote:
> (off-list since I'm likely missing something..)
>
> Hello Ming Lei,
>
> quick question -
>
> On 04/15/16 12:51, Ming Lei wrote:
>> Starting from commit e36f620428(block: split bios to max possible length),
>> block core starts to split bio in the middle of bvec.
>>
>> Unfortunately loop dio/aio doesn't consider this situation, and
>> always treat 'iter.iov_offset' as zero. Then filesystem corruption
>> is observed.
>>
>> This patch figures out the offset of the base bvevc via
>> 'bio->bi_iter.bi_bvec_done' and fixes the issue by passing the offset
>> to iov iterator.
>>
>> Fixes: e36f6204288088f (block: split bios to max possible length)
>> Cc: Keith Busch <keith.busch@intel.com>
>> Cc: Al Viro <viro@zeniv.linux.org.uk>
>> Cc: stable@vger.kernel.org (4.5)
>                              ^^^^^
>
> The previous patch went into 4.4.x-stable, so should this one not go
> into 4.4.x as well? It applies cleanly and does not seem to hurt.
> Apologies in advance if this is a bad idea. :)

You are absolutely right, this patch should have been marked as stable 4.4+,
thanks for point it out!

Jens, please let me know if you need me to resend the patch for fixing
the stable tag.

Thanks,
Ming

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] block: loop: fix filesystem corruption in case of aio/dio Ming Lei <ming.lei@canonical.com> - 2016-04-15 13:00 +0200
  Re: [PATCH] block: loop: fix filesystem corruption in case of aio/dio Holger Hoffstätte   <holger.hoffstaette@googlemail.com> - 2016-04-15 16:00 +0200
  Re: [PATCH] block: loop: fix filesystem corruption in case of aio/dio Jens Axboe <axboe@fb.com> - 2016-04-15 16:30 +0200

csiph-web