Re: [PATCH] block: loop: fix filesystem corruption in case of aio/dio

From	Jens Axboe <axboe@fb.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] block: loop: fix filesystem corruption in case of aio/dio
Date	2016-04-15 16:30 +0200
Message-ID	<rocUV-4mc-1@gated-at.bofh.it> (permalink)
References	<ro9DI-1Ev-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 04/15/2016 04:51 AM, Ming Lei wrote:
> Starting from commit e36f620428(block: split bios to max possible length),
> block core starts to split bio in the middle of bvec.
>
> Unfortunately loop dio/aio doesn't consider this situation, and
> always treat 'iter.iov_offset' as zero. Then filesystem corruption
> is observed.
>
> This patch figures out the offset of the base bvevc via
> 'bio->bi_iter.bi_bvec_done' and fixes the issue by passing the offset
> to iov iterator.
>
> Fixes: e36f6204288088f (block: split bios to max possible length)
> Cc: Keith Busch <keith.busch@intel.com>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: stable@vger.kernel.org (4.5)
> Signed-off-by: Ming Lei <ming.lei@canonical.com>

Thanks Ming, queued up.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] block: loop: fix filesystem corruption in case of aio/dio Ming Lei <ming.lei@canonical.com> - 2016-04-15 13:00 +0200
  Re: [PATCH] block: loop: fix filesystem corruption in case of aio/dio Holger Hoffstätte   <holger.hoffstaette@googlemail.com> - 2016-04-15 16:00 +0200
  Re: [PATCH] block: loop: fix filesystem corruption in case of aio/dio Jens Axboe <axboe@fb.com> - 2016-04-15 16:30 +0200

csiph-web