Re: [RESEND 07/11] pwm: sti: Initialise PWM Capture channel data

From	Thierry Reding <thierry.reding@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND 07/11] pwm: sti: Initialise PWM Capture channel data
Date	2016-04-15 16:30 +0200
Message-ID	<rocUW-4mc-9@gated-at.bofh.it> (permalink)
References	<r8h2z-18n-39@gated-at.bofh.it> <r8h2z-18n-37@gated-at.bofh.it> <rn3K2-5ST-29@gated-at.bofh.it> <robcu-32n-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Apr 15, 2016 at 01:39:41PM +0100, Lee Jones wrote:
> On Tue, 12 Apr 2016, Thierry Reding wrote:
> 
> > On Wed, Mar 02, 2016 at 03:32:05PM +0000, Lee Jones wrote:
> > [...]
> > > +struct sti_cpt_data {
> > > +	u32 snapshot[3];
> > > +	int index;
> > > +	int gpio;
> > 
> > On a side-note, this should probably use struct gpio_desc * instead of
> > an integer along with the gpiod_*() APIs for the GPIO handling.
> 
> Why would you need to do that?
> 
> of_get_named_gpio() does all that for you.

Use the of_get_named_gpio*d*() function instead. My understanding is
that referring to GPIOs by integer is deprecated and should not be used
in new code.

Thierry

Thread

Re: [RESEND 07/11] pwm: sti: Initialise PWM Capture channel data Thierry Reding <thierry.reding@gmail.com> - 2016-04-12 12:30 +0200
  Re: [RESEND 07/11] pwm: sti: Initialise PWM Capture channel data Lee Jones <lee.jones@linaro.org> - 2016-04-15 14:40 +0200
    Re: [RESEND 07/11] pwm: sti: Initialise PWM Capture channel data Thierry Reding <thierry.reding@gmail.com> - 2016-04-15 16:30 +0200
      Re: [RESEND 07/11] pwm: sti: Initialise PWM Capture channel data Lee Jones <lee.jones@linaro.org> - 2016-04-15 16:40 +0200
  Re: [RESEND 07/11] pwm: sti: Initialise PWM Capture channel data Lee Jones <lee.jones@linaro.org> - 2016-04-15 15:20 +0200
    Re: [RESEND 07/11] pwm: sti: Initialise PWM Capture channel data Thierry Reding <thierry.reding@gmail.com> - 2016-04-15 16:30 +0200

csiph-web