Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1378161
| From | Matthew Wilcox <willy@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/5] ext4: call dax_get_unmapped_area() for DAX pmd mappings |
| Date | 2016-04-13 20:30 +0200 |
| Message-ID | <rnxI5-5ve-1@gated-at.bofh.it> (permalink) |
| References | <rndq3-56a-11@gated-at.bofh.it> <rnjlL-29L-5@gated-at.bofh.it> <rnuKe-3cP-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Apr 13, 2016 at 09:08:36AM -0600, Toshi Kani wrote:
> > Could you do something like:
> >
> > #ifdef CONFIG_FS_DAX
> > struct page *read_dax_sector(struct block_device *bdev, sector_t n);
> > +unsigned long dax_get_unmapped_area(struct file *filp, unsigned long
> > addr,
> > + unsigned long len, unsigned long pgoff, unsigned long
> > flags);
> > #else
> > static inline struct page *read_dax_sector(struct block_device *bdev,
> > sector_t n)
> > {
> > return ERR_PTR(-ENXIO);
> > }
> > +#define dax_get_unmapped_area NULL
> > #endif
> >
> > in patch 1/5. Then there's no need for the ifdefs in each filesystem.
>
> I thought about it, but I do not think we can use an inline function to an
> entry point.
That's not an inline function. It's just NULL. So after the preprocessor
is done with it, it just looks like:
.get_unmapped_area = NULL,
and it won't be called by get_unmapped_area().
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 2/5] ext4: call dax_get_unmapped_area() for DAX pmd mappings Toshi Kani <toshi.kani@hpe.com> - 2016-04-12 23:00 +0200
[PATCH v2 5/5] block: call dax_get_unmapped_area() for DAX pmd mappings Toshi Kani <toshi.kani@hpe.com> - 2016-04-12 23:00 +0200
Re: [PATCH v2 2/5] ext4: call dax_get_unmapped_area() for DAX pmd mappings Matthew Wilcox <willy@linux.intel.com> - 2016-04-13 05:10 +0200
Re: [PATCH v2 2/5] ext4: call dax_get_unmapped_area() for DAX pmd mappings Toshi Kani <toshi.kani@hpe.com> - 2016-04-13 17:20 +0200
Re: [PATCH v2 2/5] ext4: call dax_get_unmapped_area() for DAX pmd mappings Matthew Wilcox <willy@linux.intel.com> - 2016-04-13 20:30 +0200
Re: [PATCH v2 2/5] ext4: call dax_get_unmapped_area() for DAX pmd mappings Toshi Kani <toshi.kani@hpe.com> - 2016-04-13 21:10 +0200
csiph-web