Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1377481
| From | Matthew Wilcox <willy@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/5] ext4: call dax_get_unmapped_area() for DAX pmd mappings |
| Date | 2016-04-13 05:10 +0200 |
| Message-ID | <rnjlL-29L-5@gated-at.bofh.it> (permalink) |
| References | <rndq3-56a-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Apr 12, 2016 at 02:39:29PM -0600, Toshi Kani wrote:
> To support DAX pmd mappings with unmodified applications,
> filesystems need to align an mmap address by the pmd size.
> @@ -708,6 +708,9 @@ const struct file_operations ext4_file_operations = {
> .open = ext4_file_open,
> .release = ext4_release_file,
> .fsync = ext4_sync_file,
> +#ifdef CONFIG_FS_DAX
> + .get_unmapped_area = dax_get_unmapped_area,
> +#endif
> .splice_read = generic_file_splice_read,
> .splice_write = iter_file_splice_write,
> .fallocate = ext4_fallocate,
Could you do something like:
#ifdef CONFIG_FS_DAX
struct page *read_dax_sector(struct block_device *bdev, sector_t n);
+unsigned long dax_get_unmapped_area(struct file *filp, unsigned long addr,
+ unsigned long len, unsigned long pgoff, unsigned long flags);
#else
static inline struct page *read_dax_sector(struct block_device *bdev,
sector_t n)
{
return ERR_PTR(-ENXIO);
}
+#define dax_get_unmapped_area NULL
#endif
in patch 1/5. Then there's no need for the ifdefs in each filesystem.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 2/5] ext4: call dax_get_unmapped_area() for DAX pmd mappings Toshi Kani <toshi.kani@hpe.com> - 2016-04-12 23:00 +0200
[PATCH v2 5/5] block: call dax_get_unmapped_area() for DAX pmd mappings Toshi Kani <toshi.kani@hpe.com> - 2016-04-12 23:00 +0200
Re: [PATCH v2 2/5] ext4: call dax_get_unmapped_area() for DAX pmd mappings Matthew Wilcox <willy@linux.intel.com> - 2016-04-13 05:10 +0200
Re: [PATCH v2 2/5] ext4: call dax_get_unmapped_area() for DAX pmd mappings Toshi Kani <toshi.kani@hpe.com> - 2016-04-13 17:20 +0200
Re: [PATCH v2 2/5] ext4: call dax_get_unmapped_area() for DAX pmd mappings Matthew Wilcox <willy@linux.intel.com> - 2016-04-13 20:30 +0200
Re: [PATCH v2 2/5] ext4: call dax_get_unmapped_area() for DAX pmd mappings Toshi Kani <toshi.kani@hpe.com> - 2016-04-13 21:10 +0200
csiph-web