Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1377702

Re: [PATCH] sched/clock: Make local_clock/cpu_clock inline

Show all headers | View raw

On 04/13/2016 11:41 AM, Ingo Molnar wrote:
>
> * Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>
>> The local_clock/cpu_clock functions were changed to prevent a double
>> identical test with sched_clock_cpu() when HAVE_UNSTABLE_SCHED_CLOCK
>> is set. That resulted in one line functions.
>>
>> As these functions are in all the cases one line functions and in the
>> hot path, it is useful to specify them as static inline in order to
>> give a strong hint to the compiler.
>>
>> After verification, it appears the compiler does not inline them
>> without this hint. Change those functions to static inline.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> ---
>>   include/linux/sched.h | 32 ++++++++++++++++++++++++++++++--
>>   kernel/sched/clock.c  | 41 -----------------------------------------
>>   2 files changed, 30 insertions(+), 43 deletions(-)
>
> Hm, this does not seem to apply to v4.6-rc3 cleanly.

Actually I based the patches on top of tip/sched/core.

Shall I rebase them against v4.6-rc3 ?


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] sched/clock: Make local_clock/cpu_clock inline Ingo Molnar <mingo@kernel.org> - 2016-04-13 11:50 +0200
  Re: [PATCH] sched/clock: Make local_clock/cpu_clock inline Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-04-13 11:50 +0200
    Re: [PATCH] sched/clock: Make local_clock/cpu_clock inline Ingo Molnar <mingo@kernel.org> - 2016-04-13 12:00 +0200
      Re: [PATCH] sched/clock: Make local_clock/cpu_clock inline Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-04-13 12:10 +0200

csiph-web