Re: [PATCH] sched/clock: Make local_clock/cpu_clock inline

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sched/clock: Make local_clock/cpu_clock inline
Date	2016-04-13 11:50 +0200
Message-ID	<rnpAR-7Is-3@gated-at.bofh.it> (permalink)
References	<rjdyi-11j-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Daniel Lezcano <daniel.lezcano@linaro.org> wrote:

> The local_clock/cpu_clock functions were changed to prevent a double
> identical test with sched_clock_cpu() when HAVE_UNSTABLE_SCHED_CLOCK
> is set. That resulted in one line functions.
> 
> As these functions are in all the cases one line functions and in the
> hot path, it is useful to specify them as static inline in order to
> give a strong hint to the compiler.
> 
> After verification, it appears the compiler does not inline them
> without this hint. Change those functions to static inline.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>  include/linux/sched.h | 32 ++++++++++++++++++++++++++++++--
>  kernel/sched/clock.c  | 41 -----------------------------------------
>  2 files changed, 30 insertions(+), 43 deletions(-)

Hm, this does not seem to apply to v4.6-rc3 cleanly.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] sched/clock: Make local_clock/cpu_clock inline Ingo Molnar <mingo@kernel.org> - 2016-04-13 11:50 +0200
  Re: [PATCH] sched/clock: Make local_clock/cpu_clock inline Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-04-13 11:50 +0200
    Re: [PATCH] sched/clock: Make local_clock/cpu_clock inline Ingo Molnar <mingo@kernel.org> - 2016-04-13 12:00 +0200
      Re: [PATCH] sched/clock: Make local_clock/cpu_clock inline Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-04-13 12:10 +0200

csiph-web