Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1377542
| From | Tomasz Figa <tomasz.figa@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 5/7] clk: samsung: exynos542x: Add the clock id for ACLK |
| Date | 2016-04-13 08:30 +0200 |
| Message-ID | <rnmtj-502-5@gated-at.bofh.it> (permalink) |
| References | <rlwQa-7k9-3@gated-at.bofh.it> <rlwQa-7k9-7@gated-at.bofh.it> <rn4G6-6Eg-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
2016-04-12 14:25 GMT+03:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>: > On 04/08/2016 07:00 AM, Chanwoo Choi wrote: >> This patch adds the clock id for ACLK clock which is source clock of AMBA AXI >> Bus. This clock should be handled in Bus frequency scaling driver. >> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> --- >> drivers/clk/samsung/clk-exynos5420.c | 85 +++++++++++++++++++++++------------- >> 1 file changed, 55 insertions(+), 30 deletions(-) > > The IDs itself look good but you are not adding only clock ID. You are > changing all of them from NULL-flags to CLK_SET_RATE_PARENT. This should > be explained in the commit message why you need it. Probably it should > be also in separate commit. +1. And CLK_SET_RATE_PARENT for a clock which has a mux as its parent is a bit suspicious, so I'd like to know the rationale for each single clock with CLK_SET_RATE_PARENT being added. Best regards, Tomasz
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support busfreq on exyno5422-odroidxu3 Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-08 07:10 +0200
[PATCH 5/7] clk: samsung: exynos542x: Add the clock id for ACLK Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-08 07:10 +0200
Re: [PATCH 5/7] clk: samsung: exynos542x: Add the clock id for ACLK Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-12 13:30 +0200
Re: [PATCH 5/7] clk: samsung: exynos542x: Add the clock id for ACLK Tomasz Figa <tomasz.figa@gmail.com> - 2016-04-13 08:30 +0200
Re: [PATCH 5/7] clk: samsung: exynos542x: Add the clock id for ACLK Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-14 08:30 +0200
[PATCH 6/7] ARM: dts: Add bus nodes using VDD_INT for Exynos542x SoC Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-08 07:10 +0200
Re: [PATCH 6/7] ARM: dts: Add bus nodes using VDD_INT for Exynos542x SoC Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-12 13:00 +0200
Re: [PATCH 6/7] ARM: dts: Add bus nodes using VDD_INT for Exynos542x SoC Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-14 01:20 +0200
[PATCH 4/7] dt-bindings: clock: Add the clock id for ACLK clock of Exynos542x SoC Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-08 07:10 +0200
Re: [PATCH 4/7] dt-bindings: clock: Add the clock id for ACLK clock of Exynos542x SoC Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-12 13:30 +0200
[PATCH 2/7] PM / devfreq: exynos: Add the detailed correlation for Exynos5422 bus Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-08 07:10 +0200
Re: [PATCH 2/7] PM / devfreq: exynos: Add the detailed correlation for Exynos5422 bus Rob Herring <robh@kernel.org> - 2016-04-11 17:50 +0200
Re: [PATCH 2/7] PM / devfreq: exynos: Add the detailed correlation for Exynos5422 bus Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-15 08:10 +0200
[PATCH 1/7] PM / devfreq: event: Add new Exynos NoC probe driver Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-08 07:10 +0200
Re: [PATCH 1/7] PM / devfreq: event: Add new Exynos NoC probe driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-12 10:10 +0200
Re: [PATCH 1/7] PM / devfreq: event: Add new Exynos NoC probe driver Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-15 07:20 +0200
Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support busfreq on exyno5422-odroidxu3 Markus Reichl <m.reichl@fivetechno.de> - 2016-04-08 15:00 +0200
Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support busfreq on exyno5422-odroidxu3 Chanwoo Choi <cwchoi00@gmail.com> - 2016-04-08 20:30 +0200
Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support busfreq on exyno5422-odroidxu3 Anand Moon <linux.amoon@gmail.com> - 2016-04-08 20:20 +0200
Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support busfreq on exyno5422-odroidxu3 Chanwoo Choi <cwchoi00@gmail.com> - 2016-04-08 20:30 +0200
Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support busfreq on exyno5422-odroidxu3 Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-11 04:20 +0200
Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support busfreq on exyno5422-odroidxu3 Anand Moon <linux.amoon@gmail.com> - 2016-04-11 06:10 +0200
Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support busfreq on exyno5422-odroidxu3 Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-11 06:10 +0200
Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support busfreq on exyno5422-odroidxu3 Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-11 06:20 +0200
csiph-web