Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1375474

Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support busfreq on exyno5422-odroidxu3

From Anand Moon <linux.amoon@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support busfreq on exyno5422-odroidxu3
Date 2016-04-11 06:10 +0200
Message-ID <rmBkL-88x-23@gated-at.bofh.it> (permalink)
References <rlwQa-7k9-3@gated-at.bofh.it> <rlJaF-7XL-13@gated-at.bofh.it> <rlJkm-82k-15@gated-at.bofh.it> <rmzCi-6O8-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Chanwoo,

On 11 April 2016 at 07:46, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Hi Anand,
>
> On 2016년 04월 09일 03:24, Chanwoo Choi wrote:
>> Hi Anand,
>>
>> On Sat, Apr 9, 2016 at 3:11 AM, Anand Moon <linux.amoon@gmail.com> wrote:
>>> Hi Chanwoo,
>>>
>
> [snip]
>
>>>>
>>>
>>> I am observing following deadlock. Both on Odroid U3 and Odroid XU4.
>>
>> Thanks for your test. I'll test it again and fix it.
>
> This possible recursive locking is fixed with following diff:
>
> Thanks for your report. I'll fix it on next patchset[1] (v9).
> [1] https://lkml.org/lkml/2016/4/8/14
>
>
> diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c
> index 28a9ae32d330..a4b0b02ee797 100644
> --- a/drivers/devfreq/governor_passive.c
> +++ b/drivers/devfreq/governor_passive.c
> @@ -102,7 +102,7 @@ static int update_devfreq_passive(struct devfreq *devfreq, unsigned long freq)
>         if (!devfreq->governor)
>                 return -EINVAL;
>
> -       mutex_lock(&devfreq->lock);
> +       mutex_lock_nested(&devfreq->lock, SINGLE_DEPTH_NESTING);
>
>         ret = devfreq->governor->get_target_freq(devfreq, &freq);
>         if (ret < 0)
>
> Best Regards,
> Chanwoo Choi
>

Thanks you for these patches on devfreq.
These changes fix the warning.

Tested-by: Anand Moon <linux.amoon@gmail.com>

Tested on Odroid XU4 and Odroid U3.

Best Regards
-Anand Moon

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support busfreq  on exyno5422-odroidxu3 Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-08 07:10 +0200
  [PATCH 5/7] clk: samsung: exynos542x: Add the clock id for ACLK Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-08 07:10 +0200
    Re: [PATCH 5/7] clk: samsung: exynos542x: Add the clock id for ACLK Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-12 13:30 +0200
      Re: [PATCH 5/7] clk: samsung: exynos542x: Add the clock id for ACLK Tomasz Figa <tomasz.figa@gmail.com> - 2016-04-13 08:30 +0200
        Re: [PATCH 5/7] clk: samsung: exynos542x: Add the clock id for ACLK Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-14 08:30 +0200
  [PATCH 6/7] ARM: dts: Add bus nodes using VDD_INT for Exynos542x SoC Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-08 07:10 +0200
    Re: [PATCH 6/7] ARM: dts: Add bus nodes using VDD_INT for Exynos542x  SoC Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-12 13:00 +0200
      Re: [PATCH 6/7] ARM: dts: Add bus nodes using VDD_INT for Exynos542x  SoC Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-14 01:20 +0200
  [PATCH 4/7] dt-bindings: clock: Add the clock id for ACLK clock of  Exynos542x SoC Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-08 07:10 +0200
    Re: [PATCH 4/7] dt-bindings: clock: Add the clock id for ACLK clock of  Exynos542x SoC Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-12 13:30 +0200
  [PATCH 2/7] PM / devfreq: exynos: Add the detailed correlation for  Exynos5422 bus Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-08 07:10 +0200
    Re: [PATCH 2/7] PM / devfreq: exynos: Add the detailed correlation  for Exynos5422 bus Rob Herring <robh@kernel.org> - 2016-04-11 17:50 +0200
      Re: [PATCH 2/7] PM / devfreq: exynos: Add the detailed correlation for  Exynos5422 bus Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-15 08:10 +0200
  [PATCH 1/7] PM / devfreq: event: Add new Exynos NoC probe driver Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-08 07:10 +0200
    Re: [PATCH 1/7] PM / devfreq: event: Add new Exynos NoC probe driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-12 10:10 +0200
      Re: [PATCH 1/7] PM / devfreq: event: Add new Exynos NoC probe driver Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-15 07:20 +0200
  Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support  busfreq on exyno5422-odroidxu3 Markus Reichl <m.reichl@fivetechno.de> - 2016-04-08 15:00 +0200
    Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support  busfreq on exyno5422-odroidxu3 Chanwoo Choi <cwchoi00@gmail.com> - 2016-04-08 20:30 +0200
  Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support  busfreq on exyno5422-odroidxu3 Anand Moon <linux.amoon@gmail.com> - 2016-04-08 20:20 +0200
    Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support  busfreq on exyno5422-odroidxu3 Chanwoo Choi <cwchoi00@gmail.com> - 2016-04-08 20:30 +0200
      Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support  busfreq on exyno5422-odroidxu3 Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-11 04:20 +0200
        Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support  busfreq on exyno5422-odroidxu3 Anand Moon <linux.amoon@gmail.com> - 2016-04-11 06:10 +0200
          Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support  busfreq on exyno5422-odroidxu3 Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-11 06:10 +0200
  Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support  busfreq on exyno5422-odroidxu3 Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-11 06:20 +0200

csiph-web