Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1379049

Re: Deleting child qdisc doesn't reset parent to default qdisc?

From Eric Dumazet <eric.dumazet@gmail.com>
Newsgroups linux.kernel
Subject Re: Deleting child qdisc doesn't reset parent to default qdisc?
Date 2016-04-14 17:50 +0200
Message-ID <rnRGP-44y-33@gated-at.bofh.it> (permalink)
References <rnQKL-3gf-29@gated-at.bofh.it> <rnR48-3Fm-83@gated-at.bofh.it> <rnRdM-3Ro-31@gated-at.bofh.it> <rnRx8-408-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, 2016-04-14 at 17:34 +0200, Jiri Kosina wrote:
> On Thu, 14 Apr 2016, Phil Sutter wrote:
> 
> > OTOH some qdiscs (CBQ, DRR, DSMARK, HFSC, HTB, QFQ) assign the default
> > one upon deletion instead of noop_qdisc, hence I would describe
> > the situation using the words 'inconsistent' and 'accident' rather than
> > 'expected'. :)
> 
> Exactly. I'd again like to stress the fact that this configuration works:
> 
> 	jikos:~ # tc qdisc show
> 	qdisc tbf 10: dev eth0 root refcnt 2 rate 800Mbit burst 131000b lat 1.0ms 
> 
> and this (after performing add/delete operation) doesn't:
> 
> 	jikos:~ # tc qdisc show
> 	qdisc tbf 10: dev eth0 root refcnt 2 rate 800Mbit burst 131000b lat 1.0ms 
> 
> It's hard to spot a difference (hint: there is none).

This is because some qdisc are not visible in the dump.


qdisc_list_add() uses a single list, so adding too much stuff in it
could slow down fast path (qdisc_lookup(), called from
qdisc_tree_reduce_backlog())

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Deleting child qdisc doesn't reset parent to default qdisc? Jiri Kosina <jikos@kernel.org> - 2016-04-14 16:50 +0200
  Re: Deleting child qdisc doesn't reset parent to default qdisc? Jiri Kosina <jikos@kernel.org> - 2016-04-14 17:00 +0200
  Re: Deleting child qdisc doesn't reset parent to default qdisc? Eric Dumazet <eric.dumazet@gmail.com> - 2016-04-14 17:10 +0200
    Re: Deleting child qdisc doesn't reset parent to default qdisc? Phil Sutter <phil@nwl.cc> - 2016-04-14 17:20 +0200
      Re: Deleting child qdisc doesn't reset parent to default qdisc? Jiri Kosina <jikos@kernel.org> - 2016-04-14 17:40 +0200
        Re: Deleting child qdisc doesn't reset parent to default qdisc? Eric Dumazet <eric.dumazet@gmail.com> - 2016-04-14 17:50 +0200
          Re: Deleting child qdisc doesn't reset parent to default qdisc? Phil Sutter <phil@nwl.cc> - 2016-04-14 18:30 +0200
            Re: Deleting child qdisc doesn't reset parent to default qdisc? Eric Dumazet <eric.dumazet@gmail.com> - 2016-04-14 18:50 +0200
      Re: Deleting child qdisc doesn't reset parent to default qdisc? Jiri Kosina <jikos@kernel.org> - 2016-04-14 18:10 +0200
        Re: Deleting child qdisc doesn't reset parent to default qdisc? Eric Dumazet <eric.dumazet@gmail.com> - 2016-04-14 19:50 +0200
          Re: Deleting child qdisc doesn't reset parent to default qdisc? Jamal Hadi Salim <jhs@mojatatu.com> - 2016-04-15 14:50 +0200
            Re: Deleting child qdisc doesn't reset parent to default qdisc? Eric Dumazet <eric.dumazet@gmail.com> - 2016-04-15 17:00 +0200

csiph-web