Re: Deleting child qdisc doesn't reset parent to default qdisc?

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: Deleting child qdisc doesn't reset parent to default qdisc?
Date	2016-04-14 18:10 +0200
Message-ID	<rnS0b-4DT-27@gated-at.bofh.it> (permalink)
References	<rnQKL-3gf-29@gated-at.bofh.it> <rnR48-3Fm-83@gated-at.bofh.it> <rnRdM-3Ro-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 14 Apr 2016, Phil Sutter wrote:

> > > I've came across the behavior where adding a child qdisc and then deleting 
> > > it again makes the networking dysfunctional (I guess that's because all of 
> > > a sudden there is absolutely no working qdisc on the device, although 
> > > there originally was a default one in the parent).
> > > 
> > > In a nutshell, is this expected behavior or bug?
> > 
> > This is the expected behavior.
> 
> OTOH some qdiscs (CBQ, DRR, DSMARK, HFSC, HTB, QFQ) assign the default
> one upon deletion instead of noop_qdisc, hence I would describe
> the situation using the words 'inconsistent' and 'accident' rather than
> 'expected'. :)

Would a patch that'd unify this in a sense that all qdiscs would assign 
the default one upon deletion acceptable?

Thanks,

-- 
Jiri Kosina
SUSE Labs

Thread

Deleting child qdisc doesn't reset parent to default qdisc? Jiri Kosina <jikos@kernel.org> - 2016-04-14 16:50 +0200
  Re: Deleting child qdisc doesn't reset parent to default qdisc? Jiri Kosina <jikos@kernel.org> - 2016-04-14 17:00 +0200
  Re: Deleting child qdisc doesn't reset parent to default qdisc? Eric Dumazet <eric.dumazet@gmail.com> - 2016-04-14 17:10 +0200
    Re: Deleting child qdisc doesn't reset parent to default qdisc? Phil Sutter <phil@nwl.cc> - 2016-04-14 17:20 +0200
      Re: Deleting child qdisc doesn't reset parent to default qdisc? Jiri Kosina <jikos@kernel.org> - 2016-04-14 17:40 +0200
        Re: Deleting child qdisc doesn't reset parent to default qdisc? Eric Dumazet <eric.dumazet@gmail.com> - 2016-04-14 17:50 +0200
          Re: Deleting child qdisc doesn't reset parent to default qdisc? Phil Sutter <phil@nwl.cc> - 2016-04-14 18:30 +0200
            Re: Deleting child qdisc doesn't reset parent to default qdisc? Eric Dumazet <eric.dumazet@gmail.com> - 2016-04-14 18:50 +0200
      Re: Deleting child qdisc doesn't reset parent to default qdisc? Jiri Kosina <jikos@kernel.org> - 2016-04-14 18:10 +0200
        Re: Deleting child qdisc doesn't reset parent to default qdisc? Eric Dumazet <eric.dumazet@gmail.com> - 2016-04-14 19:50 +0200
          Re: Deleting child qdisc doesn't reset parent to default qdisc? Jamal Hadi Salim <jhs@mojatatu.com> - 2016-04-15 14:50 +0200
            Re: Deleting child qdisc doesn't reset parent to default qdisc? Eric Dumazet <eric.dumazet@gmail.com> - 2016-04-15 17:00 +0200

csiph-web