Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1376556

Re: [PATCH 2/4] arm64: pmu: add fallback probe table

Show all headers | View raw

On Fri, Apr 08, 2016 at 04:57:05PM -0500, Jeremy Linton wrote:
> From: Mark Salter <msalter@redhat.com>
> 
> In preparation for ACPI support, add a pmu_probe_info table to
> the arm_pmu_device_probe() call. This table gets used when
> probing in the absence of a devicetree node for PMU.
> 
> Signed-off-by: Mark Salter <msalter@redhat.com>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> ---
>  arch/arm64/kernel/perf_event.c | 10 +++++++++-
>  include/linux/perf/arm_pmu.h   |  3 +++
>  2 files changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
> index f419a7c..8f12eac 100644
> --- a/arch/arm64/kernel/perf_event.c
> +++ b/arch/arm64/kernel/perf_event.c
> @@ -867,9 +867,17 @@ static const struct of_device_id armv8_pmu_of_device_ids[] = {
>  	{},
>  };
>  
> +static const struct pmu_probe_info armv8_pmu_probe_table[] = {
> +	ARMV8_PMU_PART_PROBE(ARM_CPU_PART_CORTEX_A53, armv8_a53_pmu_init),
> +	ARMV8_PMU_PART_PROBE(ARM_CPU_PART_CORTEX_A57, armv8_a57_pmu_init),
> +	PMU_PROBE(0, 0, armv8_pmuv3_init), /* if all else fails... */
> +	{ /* sentinel value */ }
> +};
> +

Hi Jeremy,

with 4.6 ThunderX PMU support was added, so I think above table is
missing a line like:

	ARMV8_PMU_PART_PROBE(CAVIUM_CPU_PART_THUNDERX, armv8_thunder_pmu_init)

Thanks,
Jan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4 v3] arm64/perf: Add ACPI support Jeremy Linton <jeremy.linton@arm.com> - 2016-04-09 00:00 +0200
  [PATCH 1/4] arm: pmu: Fix non-devicetree probing Jeremy Linton <jeremy.linton@arm.com> - 2016-04-09 00:00 +0200
  [PATCH 2/4] arm64: pmu: add fallback probe table Jeremy Linton <jeremy.linton@arm.com> - 2016-04-09 00:00 +0200
    Re: [PATCH 2/4] arm64: pmu: add fallback probe table Jan Glauber <jglauber@cavium.com> - 2016-04-12 10:30 +0200
  [PATCH 4/4] arm64: pmu: add A72 cpu type, support multiple PMU types Jeremy Linton <jeremy.linton@arm.com> - 2016-04-09 00:00 +0200
    Re: [PATCH 4/4] arm64: pmu: add A72 cpu type, support multiple PMU  types kbuild test robot <lkp@intel.com> - 2016-04-09 01:30 +0200

csiph-web