Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1374489

[PATCH 1/4] arm: pmu: Fix non-devicetree probing

Show all headers | View raw

From: Mark Salter <msalter@redhat.com>

There is a problem in the non-devicetree PMU probing where some
probe functions may get the number of supported events through
smp_call_function_any() using the arm_pmu supported_cpus mask.
But at the time the probe function is called, the supported_cpus
mask is empty so the call fails. This patch makes sure the mask
is set before calling the init function rather than after.

Signed-off-by: Mark Salter <msalter@redhat.com>
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
 drivers/perf/arm_pmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
index 32346b5..49fa845 100644
--- a/drivers/perf/arm_pmu.c
+++ b/drivers/perf/arm_pmu.c
@@ -997,8 +997,8 @@ int arm_pmu_device_probe(struct platform_device *pdev,
 		if (!ret)
 			ret = init_fn(pmu);
 	} else {
-		ret = probe_current_pmu(pmu, probe_table);
 		cpumask_setall(&pmu->supported_cpus);
+		ret = probe_current_pmu(pmu, probe_table);
 	}
 
 	if (ret) {
-- 
2.4.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4 v3] arm64/perf: Add ACPI support Jeremy Linton <jeremy.linton@arm.com> - 2016-04-09 00:00 +0200
  [PATCH 1/4] arm: pmu: Fix non-devicetree probing Jeremy Linton <jeremy.linton@arm.com> - 2016-04-09 00:00 +0200
  [PATCH 2/4] arm64: pmu: add fallback probe table Jeremy Linton <jeremy.linton@arm.com> - 2016-04-09 00:00 +0200
    Re: [PATCH 2/4] arm64: pmu: add fallback probe table Jan Glauber <jglauber@cavium.com> - 2016-04-12 10:30 +0200
  [PATCH 4/4] arm64: pmu: add A72 cpu type, support multiple PMU types Jeremy Linton <jeremy.linton@arm.com> - 2016-04-09 00:00 +0200
    Re: [PATCH 4/4] arm64: pmu: add A72 cpu type, support multiple PMU  types kbuild test robot <lkp@intel.com> - 2016-04-09 01:30 +0200

csiph-web