Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1374075
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support |
| Date | 2016-04-08 10:30 +0200 |
| Message-ID | <rlzXI-XP-7@gated-at.bofh.it> (permalink) |
| References | <rkPBw-8oO-19@gated-at.bofh.it> <rkPBw-8oO-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Apr 6, 2016 at 9:08 AM, qiujiang <qiujiang@huawei.com> wrote:
> This patch adds gpio-signaled acpi event support. It is used for
> power button on hisilicon D02 board, an arm64 platform.
>
> The corresponding DSDT file is defined as follows:
> Device(GPI0) {
> Name(_HID, "HISI0181")
> Name(_ADR, 0)
> Name(_UID, 0)
>
> Name (_CRS, ResourceTemplate () {
> Memory32Fixed (ReadWrite, 0x802e0000, 0x10000)
> Interrupt (ResourceConsumer, Level, ActiveHigh,
> Exclusive,,,) {344}
> })
>
> Device(PRTa) {
> Name (_DSD, Package () {
> Package () {
> Package () {"reg",0},
> Package () {"snps,nr-gpios",32},
> }
> })
> }
>
> Name (_AEI, ResourceTemplate () {
> GpioInt(Edge, ActiveLow, ExclusiveAndWake,
> PullUp, , " \\_SB.GPI0") {8}
> })
>
> Method (_E08, 0x0, NotSerialized) {
> Notify (\_SB.PWRB, 0x80)
> }
> }
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: qiujiang <qiujiang@huawei.com>
Admittedly I'm an ACPI novice and need help with deciding
about ACPI, but I mostly trust Mika to know these things right.
About this:
> + /* Add GPIO-signaled ACPI event support */
> + if (pp->irq)
> + acpi_gpiochip_request_interrupts(&port->gc);
It's weird to me that the driver already has a requested IRQ and
everything, now it has to request it again from ACPI.
When I look into the acpi_gpiochip_request_interrupts()
I find it weird that it is void given how much can go wrong
inside it. Should it not return an errorcode?
> + if (has_acpi_companion(dev) && pp->idx == 0)
> + pp->irq = platform_get_irq(to_platform_device(dev), 0);
As it was already fetched here and then later requested,
we still have to call acpi_gpiochip_request_interrupts()
further down the road? That is confusing to me, can you
explain what is going on?
Yours,
Linus Walleij
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v7 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button qiujiang <qiujiang@huawei.com> - 2016-04-06 09:00 +0200
[PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support qiujiang <qiujiang@huawei.com> - 2016-04-06 09:00 +0200
Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Linus Walleij <linus.walleij@linaro.org> - 2016-04-08 10:30 +0200
Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-04-08 10:40 +0200
Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Jiang Qiu <qiujiang@huawei.com> - 2016-04-11 14:50 +0200
Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-04-12 08:50 +0200
Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Jiang Qiu <qiujiang@huawei.com> - 2016-04-12 09:00 +0200
Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Linus Walleij <linus.walleij@linaro.org> - 2016-04-15 09:50 +0200
Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Jiang Qiu <qiujiang@huawei.com> - 2016-04-15 10:00 +0200
Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Linus Walleij <linus.walleij@linaro.org> - 2016-04-11 15:10 +0200
Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Jiang Qiu <qiujiang@huawei.com> - 2016-04-11 14:40 +0200
[PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property qiujiang <qiujiang@huawei.com> - 2016-04-06 09:00 +0200
Re: [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-04-06 15:00 +0200
Re: [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property Jiang Qiu <qiujiang@huawei.com> - 2016-04-07 13:50 +0200
Re: [PATCH v7 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-04-06 15:10 +0200
csiph-web