Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1379521

Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support

Show all headers | View raw

在 2016/4/15 15:40, Linus Walleij 写道:
> On Tue, Apr 12, 2016 at 8:46 AM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
>> On Mon, Apr 11, 2016 at 08:43:22PM +0800, Jiang Qiu wrote:
>>>> Currently it just complains if something goes wrong. The GPIO driver
>>>> itself can still work just fine (including interrupts).
>>>>
>>>> I'm fine to change it to return an error code.
>>> Agree, if add a error code for acpi_gpiochip_request_interrupts(), it looks more pretty.
>>>
>>> However, this function is common for other part, maybe cause any other effects if I
>>> do this change, did you think so?
>> I'm thinking what the callers are going to do with the error code.
>> Basically it means that we were not able to attach and configure ACPI
>> event GPIOs. It does not prevent GPIO drivers from functioning so they
>> probably just print out some warning message and continue probing, and
>> we already warn in acpi_gpiochip_request_interrupts() if something fails.
>>
>> Unless Linus W insists, let's just keep it as is for now :)
> I'm fine with it, don' worry.
>
> I'm just waiting for this patch set to mature so I can apply
> it.
Many thanks, I will fix these minor mentioned by Andy and get ready for the new version
ASAP.

Regards,
Jiang
>
> Yours,
> Linus Walleij
>
> .
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button qiujiang <qiujiang@huawei.com> - 2016-04-06 09:00 +0200
  [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support qiujiang <qiujiang@huawei.com> - 2016-04-06 09:00 +0200
    Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Linus Walleij <linus.walleij@linaro.org> - 2016-04-08 10:30 +0200
      Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-04-08 10:40 +0200
        Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Jiang Qiu <qiujiang@huawei.com> - 2016-04-11 14:50 +0200
          Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-04-12 08:50 +0200
            Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Jiang Qiu <qiujiang@huawei.com> - 2016-04-12 09:00 +0200
            Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Linus Walleij <linus.walleij@linaro.org> - 2016-04-15 09:50 +0200
              Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Jiang Qiu <qiujiang@huawei.com> - 2016-04-15 10:00 +0200
        Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Linus Walleij <linus.walleij@linaro.org> - 2016-04-11 15:10 +0200
      Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Jiang Qiu <qiujiang@huawei.com> - 2016-04-11 14:40 +0200
  [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property qiujiang <qiujiang@huawei.com> - 2016-04-06 09:00 +0200
    Re: [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-04-06 15:00 +0200
      Re: [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property Jiang Qiu <qiujiang@huawei.com> - 2016-04-07 13:50 +0200
  Re: [PATCH v7 0/3] gpio: dwapb: add gpio-signaled acpi event support  for power button Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-04-06 15:10 +0200

csiph-web