Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1373032

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

Show all headers | View raw

Hi Gabriele,

On Wed, 6 Apr 2016 14:50:29 +0000 Gabriele Paoloni wrote:

> Hi, sorry to be late on this
> 
> > -----Original Message-----
> > From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> > owner@vger.kernel.org] On Behalf Of Jisheng Zhang
> > Sent: 16 March 2016 11:41
> > To: jingoohan1@gmail.com; pratyush.anand@gmail.com; bhelgaas@google.com
> > Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> > kernel@lists.infradead.org; Jisheng Zhang
> > Subject: [PATCH v2] PCI: designware: move remaining rc setup code to
> > dw_pcie_setup_rc()
> > 
> > dw_pcie_setup_rc(), as its name indicates, setups the RC. But current
> > dw_pcie_host_init() also contains some necessary rc setup code.
> > 
> > Another reason: the host may lost power during suspend to ram, the RC
> > need to be re-setup after resume. The rc can't be correctly resumed
> > without the rc setup code in dw_pcie_host_init().
> > 
> > So this patch moves the code to dw_pcie_setup_rc() to address the above
> > two issues. After this patch, each pcie designware driver users could
> > call dw_pcie_setup_rc() to re-setup rc when resume back.  
> 
> I think this patch breaks the Hisilicon driver...
> 
> Our driver performs linkup setup in UEFI therefore we do not call
> dw_pcie_setup_rc(), we only call dw_pcie_host_init().

Thanks for the information. So pcie-hisi rely on UEFI to do something similar
in dw_pcie_setup_rc(), this comes to a common driver implement question: should
linux device driver rely on bootloader to configure HW device?

Is it acceptable that pcie-hisi adds a call to dw_pcie_setup_rc() in
hisi_add_pcie_port()?

Thanks,
Jisheng

> 
> Maybe better to group the part of code to be moved in as separate
> function...
> 
> Thanks and sorry for late reply.
> 
> Gab
> 
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

RE: [PATCH v2] PCI: designware: move remaining rc setup code to  dw_pcie_setup_rc() Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-04-06 17:00 +0200
  Re: [PATCH v2] PCI: designware: move remaining rc setup code to  dw_pcie_setup_rc() Jisheng Zhang <jszhang@marvell.com> - 2016-04-07 04:50 +0200
    RE: [PATCH v2] PCI: designware: move remaining rc setup code to  dw_pcie_setup_rc() Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-04-07 10:30 +0200
      Re: [PATCH v2] PCI: designware: move remaining rc setup code to  dw_pcie_setup_rc() Jisheng Zhang <jszhang@marvell.com> - 2016-04-07 10:40 +0200
        RE: [PATCH v2] PCI: designware: move remaining rc setup code to  dw_pcie_setup_rc() Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-04-07 12:10 +0200
          Re: [PATCH v2] PCI: designware: move remaining rc setup code to  dw_pcie_setup_rc() Jisheng Zhang <jszhang@marvell.com> - 2016-04-07 13:50 +0200
          Re: [PATCH v2] PCI: designware: move remaining rc setup code to  dw_pcie_setup_rc() Bjorn Helgaas <helgaas@kernel.org> - 2016-04-07 16:10 +0200
            RE: [PATCH v2] PCI: designware: move remaining rc setup code to  dw_pcie_setup_rc() Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-04-08 15:40 +0200
              Re: [PATCH v2] PCI: designware: move remaining rc setup code to  dw_pcie_setup_rc() Bjorn Helgaas <helgaas@kernel.org> - 2016-04-08 18:10 +0200
                RE: [PATCH v2] PCI: designware: move remaining rc setup code to  dw_pcie_setup_rc() Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-04-12 11:50 +0200
                Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() "Jingoo Han" <jingoohan1@gmail.com> - 2016-04-13 08:00 +0200
                RE: [PATCH v2] PCI: designware: move remaining rc setup code to  dw_pcie_setup_rc() Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-04-13 10:00 +0200
                Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() "Jingoo Han" <jingoohan1@gmail.com> - 2016-04-14 14:00 +0200
                Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() Pratyush Anand <pratyush.anand@gmail.com> - 2016-04-14 15:10 +0200
                RE: [PATCH v2] PCI: designware: move remaining rc setup code to  dw_pcie_setup_rc() Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-04-14 15:20 +0200
  Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() Pratyush Anand <pratyush.anand@gmail.com> - 2016-04-07 09:00 +0200
    RE: [PATCH v2] PCI: designware: move remaining rc setup code to  dw_pcie_setup_rc() Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-04-07 10:20 +0200

csiph-web