Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1378822
| From | Pratyush Anand <pratyush.anand@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() |
| Date | 2016-04-14 15:10 +0200 |
| Message-ID | <rnPbY-275-19@gated-at.bofh.it> (permalink) |
| References | (8 earlier) <rlH8R-6t5-9@gated-at.bofh.it> <rn37k-547-15@gated-at.bofh.it> <rnm0i-4qe-5@gated-at.bofh.it> <rnnSq-69I-25@gated-at.bofh.it> <rnO6f-14B-33@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Gabriele, On Thu, Apr 14, 2016 at 5:22 PM, Jingoo Han <jingoohan1@gmail.com> wrote: > On Wednesday, April 13, 2016 4:58 PM, Gabriele Paoloni wrote: >> >> Hi Jingoo >> >> On 13 April 2016 06:52, Jingoo Han wrote: >> > On Tuesday, April 12, 2016 6:44 PM, Gabriele Paoloni wrote: [...] >> > > So I will update the driver to call dw_pcie_setup_rc() from >> > > .host_init and ask the BIOS team to update the firmware for next >> > > releases (the driver will be backward compatible anyway). >> > > >> > > Also during my investigation I have noticed that in >> > dw_pcie_setup_rc() >> > > http://lxr.free-electrons.com/source/drivers/pci/host/pcie- >> > designware.c#L762 >> > > >> > > we use pp->mem_base rather than pp->mem_bus_addr to setup >> > > memory base and memory limit in the Type1 header...I think this >> > > is wrong right? Yes. RC's "memory base" and "memory limit" should be governed by PCI addresses and not CPU addresses. So, it should use pp->mem_bus_addr. >> > > Also I do not see why this code is needed at all since we overwrite >> > > this register when we call pci_bus_assign_resources(bus) that >> > > will end up in calling pci_setup_bridge() and then >> > > pci_setup_bridge_mmio()...? >> >> Do you have any comment on this issue above? Probably thats why things are working. Thanks for finding it. I think, /* setup memory base, memory limit */ hunk can be removed from dw_pcie_setup_rc. ~Pratyush
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-04-06 17:00 +0200
Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() Jisheng Zhang <jszhang@marvell.com> - 2016-04-07 04:50 +0200
RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-04-07 10:30 +0200
Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() Jisheng Zhang <jszhang@marvell.com> - 2016-04-07 10:40 +0200
RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-04-07 12:10 +0200
Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() Jisheng Zhang <jszhang@marvell.com> - 2016-04-07 13:50 +0200
Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() Bjorn Helgaas <helgaas@kernel.org> - 2016-04-07 16:10 +0200
RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-04-08 15:40 +0200
Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() Bjorn Helgaas <helgaas@kernel.org> - 2016-04-08 18:10 +0200
RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-04-12 11:50 +0200
Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() "Jingoo Han" <jingoohan1@gmail.com> - 2016-04-13 08:00 +0200
RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-04-13 10:00 +0200
Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() "Jingoo Han" <jingoohan1@gmail.com> - 2016-04-14 14:00 +0200
Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() Pratyush Anand <pratyush.anand@gmail.com> - 2016-04-14 15:10 +0200
RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-04-14 15:20 +0200
Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() Pratyush Anand <pratyush.anand@gmail.com> - 2016-04-07 09:00 +0200
RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-04-07 10:20 +0200
csiph-web