Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1372587

Re: [PATCH v2 3/5] dmaengine: qcom: bam_dma: add controlled remotely dt property

From Stanimir Varbanov <stanimir.varbanov@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 3/5] dmaengine: qcom: bam_dma: add controlled remotely dt property
Date 2016-04-06 17:10 +0200
Message-ID <rkXfH-5Ne-3@gated-at.bofh.it> (permalink)
References <rkI70-2F8-7@gated-at.bofh.it> <rkI70-2F8-21@gated-at.bofh.it> <rkITp-3fK-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 04/06/2016 02:44 AM, Vinod Koul wrote:
> On Wed, Apr 06, 2016 at 01:56:20AM +0300, Stanimir Varbanov wrote:
>>  Documentation/devicetree/bindings/dma/qcom_bam_dma.txt | 2 ++
>>  drivers/dma/qcom/bam_dma.c                             | 7 +++++++
> 
> The binding should be a separate patch..

I'm not sure, isn't this rule valid only when we introduce the binding
document? But if you insist I can make a separate patch.

> 
>>  
>> +	bdev->controlled_remotely = of_property_read_bool(pdev->dev.of_node,
>> +						"qcom,controlled-remotely");
>> +
> 
> we need some defaults here, how will this work with boards withe older DT.
> 

if the introduced property missing from DT node the driver behavior is
preserved.

-- 
regards,
Stan

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/5] bam dma fixes and one dt extension Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-04-06 01:00 +0200
  [PATCH v2 5/5] dmaengine: qcom: bam_dma: rename BAM_MAX_DATA_SIZE define Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-04-06 01:00 +0200
    Re: [PATCH v2 5/5] dmaengine: qcom: bam_dma: rename  BAM_MAX_DATA_SIZE define Vinod Koul <vinod.koul@intel.com> - 2016-04-06 01:50 +0200
      Re: [PATCH v2 5/5] dmaengine: qcom: bam_dma: rename BAM_MAX_DATA_SIZE  define Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-04-06 17:40 +0200
  [PATCH v2 2/5] dmaengine: qcom: bam_dma: clear BAM interrupt only if it is rised Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-04-06 01:00 +0200
    Re: [PATCH v2 2/5] dmaengine: qcom: bam_dma: clear BAM interrupt  only if it is rised Vinod Koul <vinod.koul@intel.com> - 2016-04-06 01:50 +0200
    Re: [PATCH v2 2/5] dmaengine: qcom: bam_dma: clear BAM interrupt only  if it is rised gpramod@codeaurora.org - 2016-04-11 10:00 +0200
  [PATCH v2 1/5] dmaengine: qcom: bam_dma: fix dma free memory on remove Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-04-06 01:00 +0200
  [PATCH v2 4/5] dmaengine: qcom: bam_dma: use correct pipe FIFO size Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-04-06 01:00 +0200
    Re: [PATCH v2 4/5] dmaengine: qcom: bam_dma: use correct pipe FIFO  size Vinod Koul <vinod.koul@intel.com> - 2016-04-06 01:50 +0200
  [PATCH v2 3/5] dmaengine: qcom: bam_dma: add controlled remotely dt property Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-04-06 01:00 +0200
    Re: [PATCH v2 3/5] dmaengine: qcom: bam_dma: add controlled remotely  dt property Vinod Koul <vinod.koul@intel.com> - 2016-04-06 01:50 +0200
      Re: [PATCH v2 3/5] dmaengine: qcom: bam_dma: add controlled remotely  dt property Andy Gross <andy.gross@linaro.org> - 2016-04-06 08:10 +0200
      Re: [PATCH v2 3/5] dmaengine: qcom: bam_dma: add controlled remotely  dt property Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-04-06 17:10 +0200
    Re: [PATCH v2 3/5] dmaengine: qcom: bam_dma: add controlled remotely  dt property Rob Herring <robh@kernel.org> - 2016-04-07 20:10 +0200
    Re: [PATCH v2 3/5] dmaengine: qcom: bam_dma: add controlled remotely  dt property gpramod@codeaurora.org - 2016-04-11 10:00 +0200

csiph-web