Re: [PATCH 1/3] intel_pstate: Use pr_fmt

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] intel_pstate: Use pr_fmt
Date	2016-04-06 17:10 +0200
Message-ID	<rkXfH-5Ne-11@gated-at.bofh.it> (permalink)
References	<rkFLQ-172-3@gated-at.bofh.it> <rkFLQ-172-9@gated-at.bofh.it> <rkHaX-1X2-51@gated-at.bofh.it> <rkX62-5pE-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06-04-16, 07:51, Doug Smythies wrote:
> On 2016.04.05 02:44 Srinivas Pandruvada wrote:
> > On Tue, 2016-04-05 at 13:28 -0700, Joe Perches wrote:
> >> Prefix the output using the more common kernel style.
> >> 
> >> Signed-off-by: Joe Perches <joe@perches.com>
> > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> >> ---
> >>  drivers/cpufreq/intel_pstate.c | 18 ++++++++++--------
> >>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> ...[cut, example left]...
> 
> > -		pr_warn("intel_pstate: Turbo disabled by BIOS or
> > unavailable on processor\n");
> > +		pr_warn("Turbo disabled by BIOS or unavailable on
> > processor\n");
> 
> I do  not understand.
> The common and unique string "intel_pstate" was added on purpose
> so as to provide a way to easily extract the related message from
> an otherwise huge log file.

The first line of the patch does this:

+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

which will automagically add name of the current file (intel_pstate)
before every print message printed using pr_*() helpers.

-- 
viresh

Thread

[PATCH 0/3] cpufreq: logging consistency changes Joe Perches <joe@perches.com> - 2016-04-05 22:30 +0200
  [PATCH 1/3] intel_pstate: Use pr_fmt Joe Perches <joe@perches.com> - 2016-04-05 22:30 +0200
    Re: [PATCH 1/3] intel_pstate: Use pr_fmt Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-04-06 00:00 +0200
      RE: [PATCH 1/3] intel_pstate: Use pr_fmt "Doug Smythies" <dsmythies@telus.net> - 2016-04-06 17:00 +0200
        Re: [PATCH 1/3] intel_pstate: Use pr_fmt Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-06 17:10 +0200
        Re: [PATCH 1/3] intel_pstate: Use pr_fmt Joe Perches <joe@perches.com> - 2016-04-06 17:20 +0200
          RE: [PATCH 1/3] intel_pstate: Use pr_fmt "Doug Smythies" <dsmythies@telus.net> - 2016-04-06 17:50 +0200
    Re: [PATCH 1/3] intel_pstate: Use pr_fmt Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-06 08:20 +0200
  Re: [PATCH 3/3] cpufreq: Use consistent prefixing via pr_fmt Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-06 08:30 +0200

csiph-web