Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1366921

[PATCH v2] gpio: pca953x: Use correct u16 value for register word write

Show all headers | View raw

The current implementation only uses the first byte in val,
the second byte is always 0. Change it to use cpu_to_le16
to write the two bytes into the register

Signed-off-by: Yong Li <sdliyong@gmail.com>
---
 drivers/gpio/gpio-pca953x.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index d0d3065..e66084c 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -18,6 +18,7 @@
 #include <linux/i2c.h>
 #include <linux/platform_data/pca953x.h>
 #include <linux/slab.h>
+#include <asm/unaligned.h>
 #include <linux/of_platform.h>
 #include <linux/acpi.h>
 
@@ -159,7 +160,7 @@ static int pca953x_write_regs(struct pca953x_chip *chip, int reg, u8 *val)
 		switch (chip->chip_type) {
 		case PCA953X_TYPE:
 			ret = i2c_smbus_write_word_data(chip->client,
-							reg << 1, (u16) *val);
+			    reg << 1, cpu_to_le16(get_unaligned((u16 *)val)));
 			break;
 		case PCA957X_TYPE:
 			ret = i2c_smbus_write_byte_data(chip->client, reg << 1,
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] gpio: pca953x: Use correct u16 value for register word write Yong Li <sdliyong@gmail.com> - 2016-03-30 09:00 +0200
  Re: [PATCH v2] gpio: pca953x: Use correct u16 value for register word  write Phil Reid <preid@electromag.com.au> - 2016-03-31 05:30 +0200
  Re: [PATCH v2] gpio: pca953x: Use correct u16 value for register word write Linus Walleij <linus.walleij@linaro.org> - 2016-04-01 15:00 +0200
    Re: [PATCH v2] gpio: pca953x: Use correct u16 value for register word write Yong Li <sdliyong@gmail.com> - 2016-04-01 16:40 +0200

csiph-web