Re: [PATCH v2] gpio: pca953x: Use correct u16 value for register word write

From	Yong Li <sdliyong@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] gpio: pca953x: Use correct u16 value for register word write
Date	2016-04-01 16:40 +0200
Message-ID	<rj8oW-5Jd-15@gated-at.bofh.it> (permalink)
References	<riigF-1wq-3@gated-at.bofh.it> <rj6Qb-4rL-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Yes it is a regression. I think it should be tagged for stable too

Thanks,
Yong

2016-04-01 20:51 GMT+08:00 Linus Walleij <linus.walleij@linaro.org>:
> On Wed, Mar 30, 2016 at 8:49 AM, Yong Li <sdliyong@gmail.com> wrote:
>
>> The current implementation only uses the first byte in val,
>> the second byte is always 0. Change it to use cpu_to_le16
>> to write the two bytes into the register
>>
>> Signed-off-by: Yong Li <sdliyong@gmail.com>
>
> Patch applied to fixes with Phil's review tag.
>
> It is a regression, right?
>
> Should it be tagged for stable?
>
> Yours,
> Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] gpio: pca953x: Use correct u16 value for register word write Yong Li <sdliyong@gmail.com> - 2016-03-30 09:00 +0200
  Re: [PATCH v2] gpio: pca953x: Use correct u16 value for register word  write Phil Reid <preid@electromag.com.au> - 2016-03-31 05:30 +0200
  Re: [PATCH v2] gpio: pca953x: Use correct u16 value for register word write Linus Walleij <linus.walleij@linaro.org> - 2016-04-01 15:00 +0200
    Re: [PATCH v2] gpio: pca953x: Use correct u16 value for register word write Yong Li <sdliyong@gmail.com> - 2016-04-01 16:40 +0200

csiph-web