Re: [PATCH v6 1/2] gpio: dwapb: convert device node to fwnode

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 1/2] gpio: dwapb: convert device node to fwnode
Date	2016-03-31 15:30 +0200
Message-ID	<riKPE-5Ha-9@gated-at.bofh.it> (permalink)
References	<rgM9b-2uM-1@gated-at.bofh.it> <rgM9b-2uM-11@gated-at.bofh.it> <ri4Qq-sQ-9@gated-at.bofh.it> <rimDD-4Gg-1@gated-at.bofh.it> <riz7P-55Z-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 31, 2016 at 3:51 AM, Jiang Qiu <qiujiang@huawei.com> wrote:
> 在 2016/3/30 19:38, Andy Shevchenko 写道:

>>> One suggestion for both patches: you could remove name from struct
>>> dwapb_port_property and get rid of pp->name and nobody would miss it.
>>> All it is used for is some dev_err's so the device info gets printed
>>> anyway.  For example (if I leave the irq out of the DT)
>>>
>>> gpio-dwapb ff708000.gpio: no irq for bank /soc/gpio@ff708000/gpio-controller@0
>>>
>>> is redundant.  The only additional info here from the name is the port
>>> index.  That could be added to the messages without having to get the
>>> name through the two property/of methods.
>>>
>>
>> Good suggestion! That'll make patches and code cleaner.
>>
>> Perhaps separate prepended  patch?
>>
> Hi Alan/Andy,
>
> It sounds good, I will follow this suggestion and do a test. But, what's the
> "separate prepended patch" mean?

Preparatory patch which goes first in the series.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/2] gpio: dwapb: add gpio-signaled acpi event support for power button qiujiang <qiujiang@huawei.com> - 2016-03-26 03:30 +0100
  [PATCH v6 2/2] gpio: dwapb: add gpio-signaled acpi event support qiujiang <qiujiang@huawei.com> - 2016-03-26 03:30 +0100
    Re: [PATCH v6 2/2] gpio: dwapb: add gpio-signaled acpi event support Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-03-30 13:50 +0200
      Re: [PATCH v6 2/2] gpio: dwapb: add gpio-signaled acpi event support Jiang Qiu <qiujiang@huawei.com> - 2016-03-31 03:00 +0200
  [PATCH v6 1/2] gpio: dwapb: convert device node to fwnode qiujiang <qiujiang@huawei.com> - 2016-03-26 03:30 +0100
    Re: [PATCH v6 1/2] gpio: dwapb: convert device node to fwnode Alan Tull <delicious.quinoa@gmail.com> - 2016-03-29 18:40 +0200
      Re: [PATCH v6 1/2] gpio: dwapb: convert device node to fwnode Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-03-30 13:40 +0200
        Re: [PATCH v6 1/2] gpio: dwapb: convert device node to fwnode Jiang Qiu <qiujiang@huawei.com> - 2016-03-31 03:00 +0200
          Re: [PATCH v6 1/2] gpio: dwapb: convert device node to fwnode Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-03-31 15:30 +0200

csiph-web