Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1367726

Re: [PATCH v6 1/2] gpio: dwapb: convert device node to fwnode

Show all headers | View raw

在 2016/3/30 19:38, Andy Shevchenko 写道:
> On Tue, Mar 29, 2016 at 7:30 PM, Alan Tull <delicious.quinoa@gmail.com> wrote:
>> On Fri, Mar 25, 2016 at 9:31 PM, qiujiang <qiujiang@huawei.com> wrote:
>>
>>> -               if (pp->idx == 0 &&
>>> -                   of_property_read_bool(port_np, "interrupt-controller")) {
>>> -                       pp->irq = irq_of_parse_and_map(port_np, 0);
>>> +               if (dev->of_node && pp->idx == 0 &&
>>> +                       fwnode_property_read_bool(fwnode,
>>> +                                                 "interrupt-controller")) {
>>> +                       pp->irq = irq_of_parse_and_map(to_of_node(fwnode), 0);
>>>                         if (!pp->irq) {
>>>                                 dev_warn(dev, "no irq for bank %s\n",
>>> -                                        port_np->full_name);
>>> +                                        to_of_node(fwnode)->full_name);
>>>                         }
>>>                 }
>>>
>>>                 pp->irq_shared  = false;
>>>                 pp->gpio_base   = -1;
>>> -               pp->name        = port_np->full_name;
>>> +               if (dev->of_node)
>>> +                       pp->name = to_of_node(fwnode)->full_name;
>>
>> Hi Jiang,
>>
>> I tested lightly on a CycloneV and it worked fine (with device tree).
>>
>> One suggestion for both patches: you could remove name from struct
>> dwapb_port_property and get rid of pp->name and nobody would miss it.
>> All it is used for is some dev_err's so the device info gets printed
>> anyway.  For example (if I leave the irq out of the DT)
>>
>> gpio-dwapb ff708000.gpio: no irq for bank /soc/gpio@ff708000/gpio-controller@0
>>
>> is redundant.  The only additional info here from the name is the port
>> index.  That could be added to the messages without having to get the
>> name through the two property/of methods.
>>
> 
> Good suggestion! That'll make patches and code cleaner.
> 
> Perhaps separate prepended  patch?
> 
Hi Alan/Andy,

It sounds good, I will follow this suggestion and do a test. But, what's the
"separate prepended patch" mean?

Thanks, Jiang

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/2] gpio: dwapb: add gpio-signaled acpi event support for power button qiujiang <qiujiang@huawei.com> - 2016-03-26 03:30 +0100
  [PATCH v6 2/2] gpio: dwapb: add gpio-signaled acpi event support qiujiang <qiujiang@huawei.com> - 2016-03-26 03:30 +0100
    Re: [PATCH v6 2/2] gpio: dwapb: add gpio-signaled acpi event support Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-03-30 13:50 +0200
      Re: [PATCH v6 2/2] gpio: dwapb: add gpio-signaled acpi event support Jiang Qiu <qiujiang@huawei.com> - 2016-03-31 03:00 +0200
  [PATCH v6 1/2] gpio: dwapb: convert device node to fwnode qiujiang <qiujiang@huawei.com> - 2016-03-26 03:30 +0100
    Re: [PATCH v6 1/2] gpio: dwapb: convert device node to fwnode Alan Tull <delicious.quinoa@gmail.com> - 2016-03-29 18:40 +0200
      Re: [PATCH v6 1/2] gpio: dwapb: convert device node to fwnode Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-03-30 13:40 +0200
        Re: [PATCH v6 1/2] gpio: dwapb: convert device node to fwnode Jiang Qiu <qiujiang@huawei.com> - 2016-03-31 03:00 +0200
          Re: [PATCH v6 1/2] gpio: dwapb: convert device node to fwnode Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-03-31 15:30 +0200

csiph-web