Re: [PATCH] regulator: da9053: regulators is an array, so no need to check if NULL

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] regulator: da9053: regulators is an array, so no need to check if NULL
Date	2016-03-29 19:10 +0200
Message-ID	<ri5js-TR-9@gated-at.bofh.it> (permalink)
References	<rhHAt-C5-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Mar 28, 2016 at 04:41:43PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> pdata->regulators is an array, so can never be null, so the
> null check on this array is redundant and can be removed.

What is the value in this change?  The check is always true so it will
be optimised away if the compiler is sensible but leaving it there means
that there's one less thing that can go wrong if the platform data is
changed.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: da9053: regulators is an array, so no need to check if NULL Colin King <colin.king@canonical.com> - 2016-03-28 17:50 +0200
  Re: [PATCH] regulator: da9053: regulators is an array, so no need to  check if NULL Mark Brown <broonie@kernel.org> - 2016-03-29 19:10 +0200

csiph-web